Skip to content

A platform for community discussion. Free, open, simple.

DEV: Replace `@babel/standalone` with `@babel/core` in asset-processor (#44694)

David Taylor4a26de289d4d
diff --git a/frontend/asset-processor/assert-shim.js b/frontend/asset-processor/assert-shim.js
new file mode 100644
index 00000000000..9333248805f
--- /dev/null
+++ b/frontend/asset-processor/assert-shim.js
@@ -0,0 +1,5 @@
+module.exports = function assert(value, message) {
+ if (!value) {
+ throw new Error(message);
+ }
+};
diff --git a/frontend/asset-processor/build.mjs b/frontend/asset-processor/build.mjs
index a2343bf2c89..874f2f9ec1b 100644
--- a/frontend/asset-processor/build.mjs
+++ b/frontend/asset-processor/build.mjs
@@ -21,7 +21,7 @@ const bundle = await rolldown({
url: local("./url-polyfill.js"),
// Absolute path so postcss's `browser` field (`source-map-js: false`) can't stub it out and disable CSS sourcemaps.
"source-map-js": local("source-map-js"),
- assert: local("./noop.js"),
+ assert: local("./assert-shim.js"),
fs: local("./noop.js"),
os: local("./os-shim.js"),
workerpool: local("./workerpool-shim.js"),
diff --git a/frontend/asset-processor/package.json b/frontend/asset-processor/package.json
index d3936ce0b47..91f08a143a5 100644
--- a/frontend/asset-processor/package.json
+++ b/frontend/asset-processor/package.json
@@ -11,9 +11,9 @@
},
"dependencies": {
"@babel/core": "^7.29.7",
+ "@babel/plugin-transform-modules-amd": "^7.29.7",
"@babel/plugin-transform-typescript": "^7.29.7",
"@babel/preset-env": "^7.29.2",
- "@babel/standalone": "^8.0.4",
"@csstools/postcss-light-dark-function": "^3.0.3",
"@glimmer/syntax": "^0.95.0",
"@rollup/browser": "^4.63.1",
diff --git a/frontend/asset-processor/transpiler.js b/frontend/asset-processor/transpiler.js
index 340a93f551e..0507f112fab 100644
--- a/frontend/asset-processor/transpiler.js
+++ b/frontend/asset-processor/transpiler.js
@@ -1,7 +1,9 @@
import "./shims.js";
import "./postcss.js";
import "./asset-processor-rollup.js";
-import { transform as babelTransform } from "@babel/standalone";
+import { transformSync } from "@babel/core";
+import BabelTransformModulesAmd from "@babel/plugin-transform-modules-amd";
+import BabelPresetEnv from "@babel/preset-env";
import DecoratorTransforms from "decorator-transforms";
import EMBER_PACKAGE from "ember-source/package.json";
import { minify as terserMinify } from "terser";
@@ -17,19 +19,20 @@ globalThis.transpile = function (source, options = {}) {
const plugins = [];
if (moduleId && !skipModule) {
- plugins.push(["transform-modules-amd", { noInterop: true, moduleId }]);
+ plugins.push([BabelTransformModulesAmd, { noInterop: true }]);
}
plugins.push([DecoratorTransforms, { runEarly: true }]);
plugins.push(babelTransformModuleRenames);
try {
- const result = babelTransform(source, {
+ const result = transformSync(source, {
+ moduleId,
filename,
ast: false,
plugins,
presets: [
[
- "env",
+ BabelPresetEnv,
{
modules: false,
targets: {
diff --git a/frontend/discourse/package.json b/frontend/discourse/package.json
index c1ee28d311d..6c7050c2604 100644
--- a/frontend/discourse/package.json
+++ b/frontend/discourse/package.json
@@ -114,7 +114,6 @@
"@babel/core": "^7.29.7",
"@babel/plugin-transform-runtime": "^7.29.7",
"@babel/plugin-transform-typescript": "^7.29.7",
- "@babel/standalone": "^8.0.4",
"@colors/colors": "^1.6.1",
"@discourse/itsatrap": "^2.0.10",
"@ember-decorators/component": "^7.0.0",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 10d14ec7a37..9238f09ec29 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -109,15 +109,15 @@ importers:
'@babel/core':
specifier: ^7.29.7
version: 7.29.7
+ '@babel/plugin-transform-modules-amd':
+ specifier: ^7.29.7
+ version: 7.29.7(@babel/[email protected])
'@babel/plugin-transform-typescript':
specifier: ^7.29.7
version: 7.29.7(@babel/[email protected])
'@babel/preset-env':
specifier: ^7.29.2
version: 7.29.7(@babel/[email protected])
- '@babel/standalone':
- specifier: ^8.0.4
- version: 8.0.4
'@csstools/postcss-light-dark-function':
specifier: ^3.0.3
version: 3.0.3([email protected])
@@ -461,9 +461,6 @@ importers:
'@babel/plugin-transform-typescript':
specifier: ^7.29.7
version: 7.29.7(@babel/[email protected])
- '@babel/standalone':
- specifier: ^8.0.4
- version: 8.0.4
'@colors/colors':
specifier: ^1.6.1
version: 1.6.1
@@ -1668,10 +1665,6 @@ packages:
resolution: {integrity: sha512-Nq8OhGWiZIZGV6hLHoyAKLLcJihP/xFeBMGJoUrxTX2psI8dCifzLhZISFb+VWS3wFMRDmCGw5R+dOySCqPLhw==}
engines: {node: '>=6.9.0'}
- '@babel/[email protected]':
- resolution: {integrity: sha512-z8WgyJCfEl7qGAfJJksICOL5zQPpfwa6Yew+91Txf1k3xuDtlDdDe5GX2QdIhgx0HD7oYOCLoF8Y6CwNdawJwQ==}
- engines: {node: ^22.18.0 || >=24.11.0}
-
resolution: {integrity: sha512-puq+Gf35oI24FeN11LkoUQFqv9uwNeWpxXZi/Ji3rRIoKAzKnxRaZ+Gkj0vKS9ZCiTESfng1N9LyOyXvo+m+Gg==}
engines: {node: '>=6.9.0'}
@@ -9046,8 +9039,6 @@ snapshots:
'@babel/[email protected]': {}
- '@babel/[email protected]': {}
-
dependencies:
'@babel/code-frame': 7.29.7