Skip to content

A platform for community discussion. Free, open, simple.

UX: Show creator username in voice admin rooms list (#44815)

David Battersby4c373dccd155
diff --git a/plugins/voice/admin/assets/javascripts/admin/components/voice-room-list.gjs b/plugins/voice/admin/assets/javascripts/admin/components/voice-room-list.gjs
index dda16cdf170..2f82f98fed5 100644
--- a/plugins/voice/admin/assets/javascripts/admin/components/voice-room-list.gjs
+++ b/plugins/voice/admin/assets/javascripts/admin/components/voice-room-list.gjs
@@ -12,6 +12,7 @@ import { escapeExpression } from "discourse/lib/utilities";
import DButton from "discourse/ui-kit/d-button";
import DDropdownMenu from "discourse/ui-kit/d-dropdown-menu";
import DPageSubheader from "discourse/ui-kit/d-page-subheader";
+import DUserLink from "discourse/ui-kit/d-user-link";
import dAvatar from "discourse/ui-kit/helpers/d-avatar";
import dFormatDate from "discourse/ui-kit/helpers/d-format-date";
import { i18n } from "discourse-i18n";
@@ -77,6 +78,9 @@ export default class VoiceRoomList extends Component {
<th class="d-table__header-cell">{{i18n
"voice.admin.room.name"
}}</th>
+ <th class="d-table__header-cell">{{i18n
+ "voice.admin.room.creator"
+ }}</th>
<th class="d-table__header-cell">{{i18n
"voice.admin.room.public"
}}</th>
@@ -86,9 +90,6 @@ export default class VoiceRoomList extends Component {
<th class="d-table__header-cell">{{i18n
"voice.admin.room.member_count"
}}</th>
- <th class="d-table__header-cell">{{i18n
- "voice.admin.room.creator"
- }}</th>
<th class="d-table__header-cell">{{i18n
"voice.admin.room.created_at"
}}</th>
@@ -109,6 +110,20 @@ export default class VoiceRoomList extends Component {
>{{room.name}}</strong>
</LinkTo>
</td>
+ <td class="d-table__cell --detail voice-rooms__creator">
+ <div class="d-table__mobile-label">
+ {{i18n "voice.admin.room.creator"}}
+ </div>
+ {{#if room.creator}}
+ <DUserLink
+ class="voice-rooms__creator-link"
+ @user={{room.creator}}
+ >
+ {{dAvatar room.creator imageSize="tiny"}}
+ <span>{{room.creator.username}}</span>
+ </DUserLink>
+ {{/if}}
+ </td>
<td class="d-table__cell --detail voice-rooms__public">
<div class="d-table__mobile-label">
{{i18n "voice.admin.room.public"}}
@@ -137,19 +152,6 @@ export default class VoiceRoomList extends Component {
</div>
{{room.member_count}}
</td>
- <td class="d-table__cell --detail voice-rooms__creator">
- <div class="d-table__mobile-label">
- {{i18n "voice.admin.room.creator"}}
- </div>
- {{#if room.creator}}
- <a
- data-user-card={{room.creator.username}}
- href={{room.creator.userPath}}
- >
- {{dAvatar room.creator imageSize="small"}}
- </a>
- {{/if}}
- </td>
<td class="d-table__cell --detail voice-rooms__created-at">
<div class="d-table__mobile-label">
{{i18n "voice.admin.room.created_at"}}
diff --git a/plugins/voice/assets/stylesheets/common/voice-admin.scss b/plugins/voice/assets/stylesheets/common/voice-admin.scss
index f1c1f4e006f..9efb784d2d8 100644
--- a/plugins/voice/assets/stylesheets/common/voice-admin.scss
+++ b/plugins/voice/assets/stylesheets/common/voice-admin.scss
@@ -1,12 +1,19 @@
.voice-rooms-table {
margin-top: 1.5em;
+}
- .voice-rooms {
- .voice-rooms__controls {
- display: flex;
- gap: 0.5em;
- justify-content: flex-end;
- }
+.voice-rooms {
+ &__creator-link {
+ display: flex;
+ width: fit-content;
+ align-items: center;
+ gap: var(--space-2);
+ }
+
+ &__controls {
+ display: flex;
+ gap: 0.5em;
+ justify-content: flex-end;
}
}
diff --git a/plugins/voice/spec/system/admin_voice_rooms_spec.rb b/plugins/voice/spec/system/admin_voice_rooms_spec.rb
new file mode 100644
index 00000000000..1c37b8ee451
--- /dev/null
+++ b/plugins/voice/spec/system/admin_voice_rooms_spec.rb
@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+describe "Admin voice rooms" do
+ fab!(:admin)
+ fab!(:creator, :user)
+ fab!(:room) { Fabricate(:voice_room, name: "Town hall", creator:) }
+
+ let(:user_card) { PageObjects::Components::UserCard.new }
+
+ before do
+ SiteSetting.voice_enabled = true
+ sign_in(admin)
+ end
+
+ it "shows the room creator and opens their user card" do
+ visit("/admin/plugins/voice/voice-rooms")
+
+ creator_link = find(".voice-rooms__creator-link", text: creator.username)
+ creator_link.click
+
+ expect(user_card).to be_showing_user(creator.username)
+ end
+end