A platform for community discussion. Free, open, simple.
FIX: Respect read-only permissions for chat message interactions (#42363)
Isaac Janzen4ce605eb876b
diff --git a/plugins/chat/app/services/chat/create_message_interaction.rb b/plugins/chat/app/services/chat/create_message_interaction.rbindex 42483c3b58d..6e5073d1c69 100644--- a/plugins/chat/app/services/chat/create_message_interaction.rb+++ b/plugins/chat/app/services/chat/create_message_interaction.rb@@ -50,7 +50,7 @@ module Chatenddef can_interact_with_message(guardian:, message:)- guardian.can_preview_chat_channel?(message.chat_channel)+ guardian.can_join_chat_channel?(message.chat_channel)enddef fetch_interaction(guardian:, message:, action:)diff --git a/plugins/chat/spec/requests/chat/api/channels_messages_interactions_controller_spec.rb b/plugins/chat/spec/requests/chat/api/channels_messages_interactions_controller_spec.rbindex a868d848e18..309b28e011c 100644--- a/plugins/chat/spec/requests/chat/api/channels_messages_interactions_controller_spec.rb+++ b/plugins/chat/spec/requests/chat/api/channels_messages_interactions_controller_spec.rb@@ -105,6 +105,58 @@ RSpec.describe Chat::Api::ChannelsMessagesInteractionsController doendend+ context "when user has read-only access to the category channel" do+ fab!(:read_only_group, :group)+ fab!(:read_only_category) do+ Fabricate(+ :private_category,+ group: read_only_group,+ permission_type: CategoryGroup.permission_types[:readonly],+ )+ end+ fab!(:read_only_channel) { Fabricate(:category_channel, chatable: read_only_category) }+ fab!(:read_only_message) do+ Fabricate(+ :chat_message,+ chat_channel: read_only_channel,+ user: Discourse.system_user,+ blocks: [+ {+ type: "actions",+ elements: [+ {+ action_id: "xxx",+ value: "foo",+ type: "button",+ text: {+ type: "plain_text",+ text: "Click Me",+ },+ },+ ],+ },+ ],+ )+ end++ before { read_only_group.add(current_user) }++ it "returns 404 and does not create an interaction" do+ expect do+ post "/chat/api/channels/#{read_only_channel.id}/messages/#{read_only_message.id}/interactions",+ params: {+ action_id: "xxx",+ }+ end.not_to change(Chat::MessageInteraction, :count)++ expect(response.status).to eq(404)+ expect(response.parsed_body).to include(+ "errors" => [I18n.t("not_found")],+ "error_type" => "not_found",+ )+ end+ end+context "when user is not logged in" dobefore { sign_out }diff --git a/plugins/chat/spec/services/chat/create_message_interaction_spec.rb b/plugins/chat/spec/services/chat/create_message_interaction_spec.rbindex a99b72af2f0..61c53b6cc19 100644--- a/plugins/chat/spec/services/chat/create_message_interaction_spec.rb+++ b/plugins/chat/spec/services/chat/create_message_interaction_spec.rb@@ -40,6 +40,8 @@ RSpec.describe Chat::CreateMessageInteraction doendlet(:dependencies) { { guardian: } }+ before { SiteSetting.chat_allowed_groups = Group::AUTO_GROUPS[:everyone] }+context "when all steps pass" dobefore { message.chat_channel.add(current_user) }