A platform for community discussion. Free, open, simple.
SECURITY: escape solved topic title in stream
David Battersby4d49016a2c2d
diff --git a/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rb b/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rbindex b19a7c9aec9..45f4172cde2 100644--- a/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rb+++ b/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rb@@ -62,7 +62,7 @@ class DiscourseSolved::SolvedPostSerializer < ApplicationSerializerenddef topic_title- object.topic.title+ object.topic.fancy_titleenddef truncateddiff --git a/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rb b/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rbindex 8f07aaea358..58bcccebd2d 100644--- a/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rb+++ b/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rb@@ -23,6 +23,18 @@ describe DiscourseSolved::SolvedTopicsController doexpect(result["user_solved_posts"][0]["post_id"]).to eq(answer_post.id)end+ it "returns escaped topic_title" do+ topic.update_columns(title: "<script>alert('xss')</script> test", fancy_title: nil)+ sign_in(user)++ get "/solution/by_user.json", params: { username: user.username }++ expect(response.status).to eq(200)+ title = response.parsed_body["user_solved_posts"][0]["topic_title"]++ expect(title).to eq("<script>alert(‘xss’)</script> test")+ end+it "returns 404 for a non-existent user" dosign_in(admin)