Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: escape solved topic title in stream

David Battersby4d49016a2c2d
diff --git a/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rb b/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rb
index b19a7c9aec9..45f4172cde2 100644
--- a/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rb
+++ b/plugins/discourse-solved/app/serializers/discourse_solved/solved_post_serializer.rb
@@ -62,7 +62,7 @@ class DiscourseSolved::SolvedPostSerializer < ApplicationSerializer
end
def topic_title
- object.topic.title
+ object.topic.fancy_title
end
def truncated
diff --git a/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rb b/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rb
index 8f07aaea358..58bcccebd2d 100644
--- a/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rb
+++ b/plugins/discourse-solved/spec/requests/solved_topics_controller_spec.rb
@@ -23,6 +23,18 @@ describe DiscourseSolved::SolvedTopicsController do
expect(result["user_solved_posts"][0]["post_id"]).to eq(answer_post.id)
end
+ it "returns escaped topic_title" do
+ topic.update_columns(title: "<script>alert('xss')</script> test", fancy_title: nil)
+ sign_in(user)
+
+ get "/solution/by_user.json", params: { username: user.username }
+
+ expect(response.status).to eq(200)
+ title = response.parsed_body["user_solved_posts"][0]["topic_title"]
+
+ expect(title).to eq("&lt;script&gt;alert(&lsquo;xss&rsquo;)&lt;/script&gt; test")
+ end
+
it "returns 404 for a non-existent user" do
sign_in(admin)