A platform for community discussion. Free, open, simple.
DEV: Disable post voting plugin on nested replies topics (#40305)
Mark VanLandingham5136e82b6dc5
diff --git a/plugins/discourse-post-voting/extensions/topic_extension.rb b/plugins/discourse-post-voting/extensions/topic_extension.rbindex d7dacbf4691..15f27134b0d 100644--- a/plugins/discourse-post-voting/extensions/topic_extension.rb+++ b/plugins/discourse-post-voting/extensions/topic_extension.rb@@ -13,7 +13,6 @@ module PostVoting@answers = nil@comments = nil@last_answerer = nil- @is_post_voting = nilsuper(options)end@@ -56,7 +55,7 @@ module PostVotingenddef is_post_voting?- @is_post_voting ||= SiteSetting.post_voting_enabled && subtype == Topic::POST_VOTING_SUBTYPE+ SiteSetting.post_voting_enabled && subtype == Topic::POST_VOTING_SUBTYPE && !nested_view?end# class methodsdiff --git a/plugins/discourse-post-voting/spec/models/topic_spec.rb b/plugins/discourse-post-voting/spec/models/topic_spec.rbindex 34339e9cc3b..9bc29f486d3 100644--- a/plugins/discourse-post-voting/spec/models/topic_spec.rb+++ b/plugins/discourse-post-voting/spec/models/topic_spec.rb@@ -98,6 +98,17 @@ describe Topic doexpect(topic.last_answerer.id).to eq(expected)end+ describe "#is_post_voting?" do+ before { SiteSetting.post_voting_enabled = true }++ it "returns false when the topic renders as nested" do+ SiteSetting.nested_replies_enabled = true+ Fabricate(:nested_topic, topic: topic)++ expect(topic).not_to be_is_post_voting+ end+ end+describe ".post_voting_votes" doit "should return nil if user is blank" doexpect(Topic.post_voting_votes(topic, nil)).to eq(nil)diff --git a/plugins/discourse-post-voting/spec/system/post_voting_nested_topic_spec.rb b/plugins/discourse-post-voting/spec/system/post_voting_nested_topic_spec.rbnew file mode 100644index 00000000000..6ead2d2e42a--- /dev/null+++ b/plugins/discourse-post-voting/spec/system/post_voting_nested_topic_spec.rb@@ -0,0 +1,25 @@+# frozen_string_literal: true++RSpec.describe "Post voting nested topic" do+ fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }+ fab!(:topic) { Fabricate(:topic, subtype: Topic::POST_VOTING_SUBTYPE, user: user) }+ fab!(:op) { Fabricate(:post, topic: topic, user: user, post_number: 1) }+ fab!(:root_reply) { Fabricate(:post, topic: topic, raw: "Nested reply") }+ fab!(:nested_topic) { Fabricate(:nested_topic, topic: topic) }++ let(:nested_view) { PageObjects::Pages::NestedView.new }++ before do+ SiteSetting.nested_replies_enabled = true+ SiteSetting.post_voting_enabled = true+ sign_in(user)+ end++ it "lets the user read the topic in nested view" do+ nested_view.visit_nested(topic)++ expect(nested_view).to have_nested_view+ expect(nested_view).to have_op_post+ expect(nested_view).to have_root_post(root_reply)+ end+end