A platform for community discussion. Free, open, simple.
SECURITY: add visibility check for solved endpoints
David Battersby52e46bb5a21a
diff --git a/plugins/discourse-solved/lib/discourse_solved/guardian_extensions.rb b/plugins/discourse-solved/lib/discourse_solved/guardian_extensions.rbindex cc19af215df..a58d6940475 100644--- a/plugins/discourse-solved/lib/discourse_solved/guardian_extensions.rb+++ b/plugins/discourse-solved/lib/discourse_solved/guardian_extensions.rb@@ -35,6 +35,7 @@ module DiscourseSolvedreturn false if !authenticated?return false if !topic || !post || post.post_number <= 1 || post.whisper?return false if !allow_accepted_answers?(topic)+ return false if !can_see_post?(post)return true if is_staff?diff --git a/plugins/discourse-solved/spec/lib/guardian_extensions_spec.rb b/plugins/discourse-solved/spec/lib/guardian_extensions_spec.rbindex 960e2b4864b..28ca604593c 100644--- a/plugins/discourse-solved/spec/lib/guardian_extensions_spec.rb+++ b/plugins/discourse-solved/spec/lib/guardian_extensions_spec.rb@@ -117,5 +117,33 @@ describe DiscourseSolved::GuardianExtensions douser.update!(trust_level: TrustLevel[4])expect(guardian.can_accept_answer?(topic, post)).to eq(false)end++ it "returns false when user cannot see the post" do+ group = Fabricate(:group)+ category = Fabricate(:private_category, group:)+ restricted_topic = Fabricate(:topic_with_op, category:)+ restricted_post = Fabricate(:post, topic: restricted_topic)++ SiteSetting.accept_all_solutions_allowed_groups = Group::AUTO_GROUPS[:trust_level_4]+ user.update!(trust_level: TrustLevel[4])+ Group.refresh_automatic_groups!++ expect(guardian.can_accept_answer?(restricted_topic, restricted_post)).to eq(false)+ end+ end++ describe ".can_unaccept_answer?" do+ it "returns false when user cannot see the post" do+ group = Fabricate(:group)+ category = Fabricate(:private_category, group:)+ restricted_topic = Fabricate(:topic_with_op, category:)+ restricted_post = Fabricate(:post, topic: restricted_topic)++ SiteSetting.accept_all_solutions_allowed_groups = Group::AUTO_GROUPS[:trust_level_4]+ user.update!(trust_level: TrustLevel[4])+ Group.refresh_automatic_groups!++ expect(guardian.can_unaccept_answer?(restricted_topic, restricted_post)).to eq(false)+ endendenddiff --git a/plugins/discourse-solved/spec/requests/answer_controller_spec.rb b/plugins/discourse-solved/spec/requests/answer_controller_spec.rbindex f286ac14799..1d69daa721d 100644--- a/plugins/discourse-solved/spec/requests/answer_controller_spec.rb+++ b/plugins/discourse-solved/spec/requests/answer_controller_spec.rb@@ -65,6 +65,7 @@ RSpec.describe DiscourseSolved::AnswerController doendendend+describe "#unaccept" dobefore do# Setup an accepted solution