Skip to content

A platform for community discussion. Free, open, simple.

SECURITY: Don't leak restricted tag group names via tag info

Joffrey JAFFEUX532fdc10314a
diff --git a/app/serializers/detailed_tag_serializer.rb b/app/serializers/detailed_tag_serializer.rb
index 522f8b6239b..a533e631b17 100644
--- a/app/serializers/detailed_tag_serializer.rb
+++ b/app/serializers/detailed_tag_serializer.rb
@@ -22,6 +22,9 @@ class DetailedTagSerializer < TagSerializer
end
def tag_group_names
- object.tag_groups.map(&:name)
+ TagGroup
+ .visible(scope)
+ .where(id: object.tag_group_memberships.select(:tag_group_id))
+ .pluck(:name)
end
end
diff --git a/spec/requests/tags_controller_spec.rb b/spec/requests/tags_controller_spec.rb
index 66cb0c006e2..32c186d29f5 100644
--- a/spec/requests/tags_controller_spec.rb
+++ b/spec/requests/tags_controller_spec.rb
@@ -781,6 +781,40 @@ RSpec.describe TagsController do
expect(response.parsed_body["categories"]).to be_blank
expect(response.parsed_body.dig("tag_info", "category_restricted")).to eq(true)
end
+
+ it "doesn't leak the restricted tag group name to users without access" do
+ SiteSetting.tags_listed_by_group = true
+ sign_in(user)
+ get "/tag/#{tag.name}/info.json"
+ expect(response.status).to eq(200)
+ expect(response.parsed_body.dig("tag_info", "tag_group_names")).to eq([])
+ end
+
+ it "doesn't leak the restricted tag group name to anon" do
+ SiteSetting.tags_listed_by_group = true
+ get "/tag/#{tag.name}/info.json"
+ expect(response.status).to eq(200)
+ expect(response.parsed_body.dig("tag_info", "tag_group_names")).to eq([])
+ end
+
+ it "still returns the restricted tag group name to admins" do
+ SiteSetting.tags_listed_by_group = true
+ sign_in(admin)
+ get "/tag/#{tag.name}/info.json"
+ expect(response.status).to eq(200)
+ expect(response.parsed_body.dig("tag_info", "tag_group_names")).to eq([tag_group.name])
+ end
+
+ it "returns only visible tag group names when tag is in multiple groups" do
+ SiteSetting.tags_listed_by_group = true
+ public_tag_group = Fabricate(:tag_group, name: "public-group", tags: [tag])
+ sign_in(user)
+ get "/tag/#{tag.name}/info.json"
+ expect(response.status).to eq(200)
+ expect(response.parsed_body.dig("tag_info", "tag_group_names")).to eq(
+ [public_tag_group.name],
+ )
+ end
end
end
end