Skip to content

A platform for community discussion. Free, open, simple.

UX: show report loading spinners immediately on date range change (#42570)

Osama Sayegh55ad1bc56830
diff --git a/frontend/discourse/admin/components/dashboard/reports.gjs b/frontend/discourse/admin/components/dashboard/reports.gjs
index 5266a27f889..3ac7dc9795e 100644
--- a/frontend/discourse/admin/components/dashboard/reports.gjs
+++ b/frontend/discourse/admin/components/dashboard/reports.gjs
@@ -31,12 +31,6 @@ export default class DashboardReports extends Component {
constructor() {
super(...arguments);
- this.cards = this.items.map((item) => ({
- ...item,
- payload: null,
- error: false,
- isLoading: true,
- }));
this.loadPayloads();
}
@@ -78,6 +72,13 @@ export default class DashboardReports extends Component {
return;
}
+ this.cards = this.items.map((item) => ({
+ ...item,
+ payload: null,
+ error: false,
+ isLoading: true,
+ }));
+
this.loading = true;
try {
const results = await loadDashboardReports({
diff --git a/frontend/discourse/tests/integration/components/dashboard/reports-test.gjs b/frontend/discourse/tests/integration/components/dashboard/reports-test.gjs
index b6175d0eb34..a976d425795 100644
--- a/frontend/discourse/tests/integration/components/dashboard/reports-test.gjs
+++ b/frontend/discourse/tests/integration/components/dashboard/reports-test.gjs
@@ -1,3 +1,4 @@
+import { tracked } from "@glimmer/tracking";
import { hash } from "@ember/helper";
import { render, settled, waitFor } from "@ember/test-helpers";
import { module, test } from "qunit";
@@ -142,6 +143,79 @@ module("Integration | Component | DashboardReports", function (hooks) {
.hasText("signups", "a successful report renders its content");
});
+ test("shows a loading spinner immediately when the date range changes, instead of the stale chart", async function (assert) {
+ registerAdminDashboardReportRenderer("test_source", FakeReportRenderer);
+
+ let resolveSecondFetch;
+ let fetchCount = 0;
+ pretender.post("/admin/dashboard/reports/bulk", () => {
+ fetchCount++;
+ if (fetchCount === 1) {
+ return response({
+ items: [
+ {
+ source: "test_source",
+ identifier: "signups",
+ key: "test_source:signups",
+ data: { type: "signups", empty: false },
+ },
+ ],
+ });
+ }
+ return new Promise((resolve) => (resolveSecondFetch = resolve));
+ });
+
+ class State {
+ @tracked startDate = "2026-01-01";
+ }
+ const state = new State();
+ const singleItem = [ITEMS[0]];
+
+ await render(
+ <template>
+ <DashboardReports
+ @data={{hash items=singleItem}}
+ @startDate={{state.startDate}}
+ />
+ </template>
+ );
+
+ assert
+ .dom('[data-identifier="test_source:signups"] .fake-report-renderer')
+ .exists("the initial load renders real content");
+
+ state.startDate = "2026-02-01";
+ await waitFor(
+ '[data-identifier="test_source:signups"] .loading-container.visible'
+ );
+ assert
+ .dom('[data-identifier="test_source:signups"] .loading-container.visible')
+ .exists("changing the date range shows a loading spinner immediately");
+ assert
+ .dom('[data-identifier="test_source:signups"] .fake-report-renderer')
+ .doesNotExist(
+ "the stale chart is replaced by the spinner rather than left showing"
+ );
+
+ resolveSecondFetch(
+ response({
+ items: [
+ {
+ source: "test_source",
+ identifier: "signups",
+ key: "test_source:signups",
+ data: { type: "signups", empty: false },
+ },
+ ],
+ })
+ );
+ await settled();
+
+ assert
+ .dom('[data-identifier="test_source:signups"] .fake-report-renderer')
+ .exists("the chart renders again once the new range's data resolves");
+ });
+
test("clears every card's loading state when the whole bulk request fails", async function (assert) {
pretender.post("/admin/dashboard/reports/bulk", () => response(500, {}));