A platform for community discussion. Free, open, simple.
FIX: Handle invalid posting-review enum values in category update endpoint (#42196)
Isaac Janzen55ecb9feae08
diff --git a/app/models/category_setting.rb b/app/models/category_setting.rbindex 429edee31b2..c24c05b0c45 100644--- a/app/models/category_setting.rb+++ b/app/models/category_setting.rb@@ -8,10 +8,12 @@ class CategorySetting < ActiveRecord::Baseenum :topic_posting_review_mode,{ no_one: 0, everyone: 1, everyone_except: 2, no_one_except: 3 },- prefix: true+ prefix: true,+ validate: trueenum :reply_posting_review_mode,{ no_one: 0, everyone: 1, everyone_except: 2, no_one_except: 3 },- prefix: true+ prefix: true,+ validate: trueafter_save :clear_nested_replies_conversion_completed,if: :saved_change_to_nested_replies_default?diff --git a/spec/requests/categories_controller_spec.rb b/spec/requests/categories_controller_spec.rbindex 20bb8965d11..ed3c521e410 100644--- a/spec/requests/categories_controller_spec.rb+++ b/spec/requests/categories_controller_spec.rb@@ -1311,6 +1311,26 @@ RSpec.describe CategoriesController doexpect(category.reply_posting_review_group_ids).to contain_exactly(mod_group_3.id)end+ it "returns 422 for invalid posting review modes" do+ %w[topic_posting_review_mode reply_posting_review_mode].each do |review_mode|+ expect do+ put "/categories/#{category.id}.json",+ params: {+ category_setting_attributes: {+ review_mode => "invalid",+ },+ }+ end.not_to raise_error++ expect(response).to have_http_status(:unprocessable_entity)+ expect(response.parsed_body["errors"].join(" ").downcase).to include(+ review_mode.humanize.downcase,+ "is not included in the list",+ )+ expect(category.reload.category_setting.public_send(review_mode)).to eq("no_one")+ end+ end+it "can correctly convert blank strings to appropriate null values" doput "/categories/#{category.id}.json", params: { email_in: "", minimum_required_tags: "" }expect(response.status).to eq(200)