A platform for community discussion. Free, open, simple.
FIX: Make user field checkboxes usable on the code login page (#41626)
Keegan George55f7851b7e44
diff --git a/app/assets/stylesheets/common/base/login-signup-page.scss b/app/assets/stylesheets/common/base/login-signup-page.scssindex 8df5ec8b5a4..c5b53ab63fc 100644--- a/app/assets/stylesheets/common/base/login-signup-page.scss+++ b/app/assets/stylesheets/common/base/login-signup-page.scss@@ -607,9 +607,10 @@ body.signup-page {}}-// Signup and invite page+// Signup, invite, and code login pages share the user-fields step.invite-page,-.signup-fullpage {+.signup-fullpage,+.login-fullpage {.password-confirmation {display: none;}diff --git a/spec/system/code_login_spec.rb b/spec/system/code_login_spec.rbindex 109497e6420..838cf5399ec 100644--- a/spec/system/code_login_spec.rb+++ b/spec/system/code_login_spec.rb@@ -100,6 +100,48 @@ describe "Login via email code" doexpect(page).to have_css(".header-dropdown-toggle.current-user")end+ context "with a required checkbox user field" do+ fab!(:user_field) do+ Fabricate(:user_field, name: "Terms", field_type: "confirm", required: true)+ end++ it "renders the checkbox at a usable size and lets it be toggled" do+ new_email = "[email protected]"++ visit("/login")+ expect(page).to have_css("#login-account-name")+ find("#one-time-code-link").click+ expect(page).to have_css(".code-login-form__email-step")++ find(".code-login-form__email-step input[type='email']").fill_in(with: new_email)+ find(".code-login-form__continue").click+ expect(page).to have_css(".code-login-form__code-step")++ fill_code(latest_emailed_code(new_email))++ expect(page).to have_css(".code-login-form__user-fields-step")+ screenshot_marker(label: "code-login-user-fields-step")++ checkbox = find(".user-field.confirm input[type='checkbox']")++ # Regression: the shared `.input-group input` rule stretches inputs to+ # `min-width: 250px; width: 100%`. Without the checkbox override applying+ # to `.login-fullpage`, the checkbox renders as a full-width bar. Assert it+ # stays small.+ expect(checkbox.evaluate_script("this.offsetWidth")).to be < 50++ checkbox.click+ expect(checkbox).to be_checked++ find(".code-login-form__user-fields-step .code-login-form__verify").click++ expect(page).to have_css(".code-login-form__complete-step")++ user = User.find_by_email(new_email)+ expect(user.custom_fields["user_field_#{user_field.id}"]).to eq("true")+ end+ end+context "when the setting is disabled" dobefore { SiteSetting.enable_local_logins_via_code = false }