A platform for community discussion. Free, open, simple.
DEV: Add a cache to the JSON:API glossary (#43315)
Loïc Guitaut56175ea6e1ce
diff --git a/lib/json_api_kit/glossary.rb b/lib/json_api_kit/glossary.rbindex ea55a93528e..985baf4f4c5 100644--- a/lib/json_api_kit/glossary.rb+++ b/lib/json_api_kit/glossary.rb@@ -36,20 +36,24 @@ module JsonApiKitdef initialize(rules)@rules = rules+ @declared_names = {}+ @member_names = {}enddef declared_name(name)- rules.reduce(name) { |result, rule| rule.declared_name(result) }+ declared_names[name] ||= rules.reduce(name) { |result, rule| rule.declared_name(result) }rescue Correction => correctionraise NotAMemberName.new(name, member_name(correction.name))enddef member_name(name)- rules.reverse_each.reduce(name) { |member, rule| rule.member_name(member) }+ member_names[name] ||= rules+ .reverse_each+ .reduce(name) { |result, rule| rule.member_name(result) }endprivate- attr_reader :rules+ attr_reader :rules, :declared_names, :member_namesendenddiff --git a/spec/lib/json_api_kit/glossary_spec.rb b/spec/lib/json_api_kit/glossary_spec.rbindex bdd76d2f148..52610724c62 100644--- a/spec/lib/json_api_kit/glossary_spec.rb+++ b/spec/lib/json_api_kit/glossary_spec.rb@@ -74,6 +74,32 @@ RSpec.describe JsonApiKit::Glossary doexpect(declared_name).to eq(name.with(value: "created_at"))end+ context "when the name was converted before" do+ before do+ allow(described_class::CasingRule).to receive(:declared_name).and_call_original+ glossary.declared_name(name)+ end++ it "does not ask the rules again" do+ declared_name+ expect(described_class::CasingRule).to have_received(:declared_name).once+ end+ end++ context "when the name was refused before" do+ let(:value) { "created_at" }++ before do+ allow(described_class::CasingRule).to receive(:declared_name).and_call_original+ suppress(described_class::NotAMemberName) { glossary.declared_name(name) }+ end++ it "asks the rules again" do+ suppress(described_class::NotAMemberName) { declared_name }+ expect(described_class::CasingRule).to have_received(:declared_name).twice+ end+ end+context "when the name is not a member name" dolet(:value) { "created_at" }@@ -151,6 +177,18 @@ RSpec.describe JsonApiKit::Glossary doexpect(member_name).to eq(name.with(value: "createdAt"))end+ context "when the name was converted before" do+ before do+ allow(described_class::CasingRule).to receive(:member_name).and_call_original+ glossary.member_name(name)+ end++ it "does not ask the rules again" do+ member_name+ expect(described_class::CasingRule).to have_received(:member_name).once+ end+ end+context "with a version rule" dosubject(:glossary) { described_class.resource(version) }