Skip to content

A platform for community discussion. Free, open, simple.

FIX: Properly URL-encode reaction value when fetching reaction users (#40218)

Régis Hanol579c368cf59f
diff --git a/plugins/discourse-reactions/assets/javascripts/discourse/models/discourse-reactions-custom-reaction.js b/plugins/discourse-reactions/assets/javascripts/discourse/models/discourse-reactions-custom-reaction.js
index 272c74d10b1..13d8dbaf4a2 100644
--- a/plugins/discourse-reactions/assets/javascripts/discourse/models/discourse-reactions-custom-reaction.js
+++ b/plugins/discourse-reactions/assets/javascripts/discourse/models/discourse-reactions-custom-reaction.js
@@ -104,12 +104,13 @@ export default class CustomReaction extends RestModel {
}
static findReactionUsers(postId, options = {}) {
- let url = `/discourse-reactions/posts/${postId}/reactions-users.json`;
+ const data = {};
if (options.reactionValue) {
- url += `?reaction_value=${options.reactionValue}`;
+ data.reaction_value = options.reactionValue;
}
- return ajax(url, {
+ return ajax(`/discourse-reactions/posts/${postId}/reactions-users.json`, {
type: "GET",
+ data,
}).then((result) => {
const reactionUsers = result.reaction_users.map((reactionUser) => {
reactionUser.users = reactionUser.users.map((user) =>
diff --git a/plugins/discourse-reactions/spec/system/page_objects/post_reactions_list.rb b/plugins/discourse-reactions/spec/system/page_objects/post_reactions_list.rb
index bf86265724f..40c907749b5 100644
--- a/plugins/discourse-reactions/spec/system/page_objects/post_reactions_list.rb
+++ b/plugins/discourse-reactions/spec/system/page_objects/post_reactions_list.rb
@@ -20,7 +20,7 @@ module PageObjects
end
def reaction_list_emoji_selector(reaction)
- "#discourse-reactions-list-emoji-#{post_id}-#{reaction}"
+ %([id="discourse-reactions-list-emoji-#{post_id}-#{reaction}"])
end
def has_reaction?(reaction)
diff --git a/plugins/discourse-reactions/spec/system/reactions_post_spec.rb b/plugins/discourse-reactions/spec/system/reactions_post_spec.rb
index 20e017f443b..99e8102fca2 100644
--- a/plugins/discourse-reactions/spec/system/reactions_post_spec.rb
+++ b/plugins/discourse-reactions/spec/system/reactions_post_spec.rb
@@ -108,4 +108,25 @@ describe "Reactions | Post reactions" do
expect(reactions_button).to have_no_emoji_picker_emoji("middle_finger")
end
end
+
+ context "when hovering over a reaction whose value contains a URL-reserved character" do
+ fab!(:other_user, :user)
+
+ before do
+ DiscourseReactions::ReactionManager.new(
+ reaction_value: "+1",
+ user: other_user,
+ post: post_2,
+ ).toggle!
+ end
+
+ it "loads the reaction users in the hover popup" do
+ visit post_2.url
+ expect(reactions_list).to have_reaction("+1")
+
+ reactions_list.hover_over_reaction("+1")
+
+ expect(reactions_list).to have_users_for_reaction("+1", [other_user.username])
+ end
+ end
end