Skip to content

A platform for community discussion. Free, open, simple.

DEV: Another approach to csv spec flakes (#40542)

Jarek Radosz58ea8baec876
diff --git a/spec/system/helpers/downloads.rb b/spec/system/helpers/downloads.rb
index c124e5ac0c8..ca4f397f6e4 100644
--- a/spec/system/helpers/downloads.rb
+++ b/spec/system/helpers/downloads.rb
@@ -2,24 +2,6 @@
class Downloads
FOLDER = Rails.root.join("tmp/downloads")
- TIMEOUT = 10
-
- # Waits for `path` to appear and finish writing.
- def self.wait_for(path)
- previous_size = -1
- Timeout.timeout(TIMEOUT) do
- loop do
- size = File.size?(path)
- break if size == previous_size
-
- previous_size = size if size
- sleep 0.1
- end
- end
- rescue Timeout::Error
- last = previous_size == -1 ? "never appeared" : "last size #{previous_size}"
- raise Timeout::Error, "Timed out after #{TIMEOUT}s waiting for #{path} (#{last})"
- end
def self.clear
FileUtils.rm_rf(FOLDER)
diff --git a/spec/system/page_objects/pages/csv_export_pm.rb b/spec/system/page_objects/pages/csv_export_pm.rb
index b33d87fd8ca..66948d6fc07 100644
--- a/spec/system/page_objects/pages/csv_export_pm.rb
+++ b/spec/system/page_objects/pages/csv_export_pm.rb
@@ -10,14 +10,12 @@ module PageObjects
def download_and_extract
original_save_path = Capybara.save_path
- Capybara.save_path = Downloads::FOLDER
+ Capybara.save_path = Downloads::FOLDER.join("_unused")
- zip_name = find("a.attachment").text
- zip_path = File.join(Downloads::FOLDER, zip_name)
- @downloaded_files << zip_path
-
- page.driver.with_playwright_page { |pw_page| pw_page.expect_download { click_link ".zip" } }
- Downloads.wait_for(zip_path)
+ zip_path =
+ page.driver.with_playwright_page do |pw_page|
+ pw_page.expect_download { click_link ".zip" }.path
+ end
csv_path = unzip(zip_path).first
@downloaded_files << csv_path