Skip to content

A platform for community discussion. Free, open, simple.

DEV: Fix flaky assignee selection in assign modal specs (#44121)

Gabriel Grubba59a8a50e1ee8
diff --git a/plugins/discourse-assign/spec/system/page_objects/modals/assign.rb b/plugins/discourse-assign/spec/system/page_objects/modals/assign.rb
index 2a33f6e540e..865604293a8 100644
--- a/plugins/discourse-assign/spec/system/page_objects/modals/assign.rb
+++ b/plugins/discourse-assign/spec/system/page_objects/modals/assign.rb
@@ -5,8 +5,8 @@ module PageObjects
class Assign < PageObjects::Modals::Base
def assignee=(assignee)
assignee = assignee.is_a?(Group) ? assignee.name : assignee.username
- find(".control-group input").fill_in(with: assignee)
- find("li[data-value='#{assignee}']").click
+ assignee_chooser.search(assignee)
+ assignee_chooser.select_row_by_value(assignee)
end
def select_assignee_with_keyboard(assignee)
@@ -29,6 +29,12 @@ module PageObjects
def confirm
find(".d-modal__footer .btn-primary").click
end
+
+ private
+
+ def assignee_chooser
+ @assignee_chooser ||= PageObjects::Components::SelectKit.new("#assignee-chooser")
+ end
end
end
end