A platform for community discussion. Free, open, simple.
FIX: make chat recipient lookup case-insensitive (#43020)
Renato Atilio5b1600aa9629
diff --git a/plugins/chat/app/queries/chat/users_from_usernames_and_groups_query.rb b/plugins/chat/app/queries/chat/users_from_usernames_and_groups_query.rbindex 1606e07f70f..34d246b4423 100644--- a/plugins/chat/app/queries/chat/users_from_usernames_and_groups_query.rb+++ b/plugins/chat/app/queries/chat/users_from_usernames_and_groups_query.rb@@ -11,8 +11,8 @@ module Chat.left_outer_joins(:groups).where(user_options: opts).where(- "username IN (?) OR (groups.name IN (?) AND group_users.user_id IS NOT NULL)",- usernames&.map(&:to_s),+ "users.username_lower IN (?) OR (groups.name IN (?) AND group_users.user_id IS NOT NULL)",+ usernames&.map { |username| User.normalize_username(username.to_s) },groups&.map(&:to_s),).where.not(id: excluded_user_ids)diff --git a/plugins/chat/spec/queries/chat/users_from_usernames_and_groups_query_spec.rb b/plugins/chat/spec/queries/chat/users_from_usernames_and_groups_query_spec.rbindex c611b4eee93..87621e12bd5 100644--- a/plugins/chat/spec/queries/chat/users_from_usernames_and_groups_query_spec.rb+++ b/plugins/chat/spec/queries/chat/users_from_usernames_and_groups_query_spec.rb@@ -14,6 +14,14 @@ describe Chat::UsersFromUsernamesAndGroupsQuery doexpect(result).to contain_exactly(user1, user4)end+ it "matches usernames case-insensitively" do+ user = Fabricate(:user, username: "MixedCase")++ result = described_class.call(usernames: [user.username.downcase], groups: [])++ expect(result).to contain_exactly(user)+ end+it "works with a number" douser = Fabricate(:user, username: 12_345_678)result = described_class.call(usernames: [12_345_678], groups: [])