A platform for community discussion. Free, open, simple.
FIX: Maintain rotation for video uploads to AWS (#41767)
Natalie Tay5b9de8b1000c
diff --git a/app/services/video_conversion/aws_media_convert_adapter.rb b/app/services/video_conversion/aws_media_convert_adapter.rbindex 41b679e34f4..61287d1e82e 100644--- a/app/services/video_conversion/aws_media_convert_adapter.rb+++ b/app/services/video_conversion/aws_media_convert_adapter.rb@@ -428,6 +428,7 @@ module VideoConversion},},video_selector: {+ rotate: "AUTO",},},],diff --git a/spec/services/video_conversion/aws_media_convert_adapter_spec.rb b/spec/services/video_conversion/aws_media_convert_adapter_spec.rbindex b28eeccbc42..b243a7755e9 100644--- a/spec/services/video_conversion/aws_media_convert_adapter_spec.rb+++ b/spec/services/video_conversion/aws_media_convert_adapter_spec.rb@@ -106,6 +106,18 @@ RSpec.describe VideoConversion::AwsMediaConvertAdapter doallow(OptimizedVideo).to receive(:create_for)end+ describe ".build_conversion_settings" do+ it "honors rotation metadata from uploaded videos" do+ settings =+ described_class.build_conversion_settings(+ "s3://#{s3_bucket}/uploads/default/original/test.mp4",+ new_sha1,+ )++ expect(settings[:inputs].first[:video_selector]).to eq(rotate: "AUTO")+ end+ end+describe "#convert" dolet(:output_path) do"/uploads/default/test_#{Discourse.test_env_number}/original/1X/#{new_sha1}"