Skip to content

A platform for community discussion. Free, open, simple.

DEV: Remove unused `valid?` from workflow button nodes

Régis Hanol5c2c6dda7678
diff --git a/plugins/discourse-workflows/lib/discourse_workflows/nodes/post_button/v1.rb b/plugins/discourse-workflows/lib/discourse_workflows/nodes/post_button/v1.rb
index b573422da34..2c9c86a56f8 100644
--- a/plugins/discourse-workflows/lib/discourse_workflows/nodes/post_button/v1.rb
+++ b/plugins/discourse-workflows/lib/discourse_workflows/nodes/post_button/v1.rb
@@ -184,10 +184,6 @@ module DiscourseWorkflows
@post = post
end
- def valid?
- @post.present? && @post.topic.present?
- end
-
def output
{ post: post_data(@post), topic: topic_data(@post.topic) }
end
diff --git a/plugins/discourse-workflows/lib/discourse_workflows/nodes/topic_admin_button/v1.rb b/plugins/discourse-workflows/lib/discourse_workflows/nodes/topic_admin_button/v1.rb
index 0b0f48fe6d3..872cb4f4d6d 100644
--- a/plugins/discourse-workflows/lib/discourse_workflows/nodes/topic_admin_button/v1.rb
+++ b/plugins/discourse-workflows/lib/discourse_workflows/nodes/topic_admin_button/v1.rb
@@ -34,15 +34,9 @@ module DiscourseWorkflows
@topic = topic
end
- def valid?
- @topic.present?
- end
-
def output
{ topic: topic_data(@topic) }
end
-
- private
end
end
end
diff --git a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/post_button_spec.rb b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/post_button_spec.rb
index e53d0d59e55..bc6700c0d9a 100644
--- a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/post_button_spec.rb
+++ b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/post_button_spec.rb
@@ -5,18 +5,6 @@ RSpec.describe DiscourseWorkflows::Nodes::PostButton::V1 do
fab!(:user)
fab!(:post)
- describe "#valid?" do
- it "returns true when the post is present" do
- trigger = described_class.new(post)
- expect(trigger).to be_valid
- end
-
- it "returns false when the post is nil" do
- trigger = described_class.new(nil)
- expect(trigger).not_to be_valid
- end
- end
-
describe "#output" do
it "returns post and topic data" do
output = described_class.new(post).output
diff --git a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/topic_admin_button_spec.rb b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/topic_admin_button_spec.rb
index 16a0448efd3..ff6754f0c49 100644
--- a/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/topic_admin_button_spec.rb
+++ b/plugins/discourse-workflows/spec/lib/discourse_workflows/nodes/topic_admin_button_spec.rb
@@ -9,18 +9,6 @@ RSpec.describe DiscourseWorkflows::Nodes::TopicAdminButton::V1 do
topic.tags << tag
end
- describe "#valid?" do
- it "returns true when topic is present" do
- trigger = described_class.new(topic)
- expect(trigger).to be_valid
- end
-
- it "returns false when topic is nil" do
- trigger = described_class.new(nil)
- expect(trigger).not_to be_valid
- end
- end
-
describe "#output" do
it "returns topic data" do
output = described_class.new(topic).output