A platform for community discussion. Free, open, simple.
FIX: Render group_list settings in AI feature editor (#39199)
Krzysztof Kotlarek5c462210725c
diff --git a/plugins/discourse-ai/admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/edit.gjs b/plugins/discourse-ai/admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/edit.gjsindex 0e3bf169261..5ebf894c21b 100644--- a/plugins/discourse-ai/admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/edit.gjs+++ b/plugins/discourse-ai/admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/edit.gjs@@ -2,7 +2,7 @@ import { concat } from "@ember/helper";import AdminConfigAreaCard from "discourse/admin/components/admin-config-area-card";import BackButton from "discourse/components/back-button";import Form from "discourse/components/form";-import { eq } from "discourse/truth-helpers";+import { eq, or } from "discourse/truth-helpers";import { i18n } from "discourse-i18n";import AiFeatureSettingField from "discourse/plugins/discourse-ai/discourse/components/ai-feature-setting-field";@@ -55,11 +55,13 @@ export default <template>(eq setting.type "enum")"select"(if- (eq setting.type "category_list")- "custom"- (if- (eq setting.type "list") "custom" "input"+ (or+ (eq setting.type "category_list")+ (eq setting.type "group_list")+ (eq setting.type "list"))+ "custom"+ "input")))@@ -97,7 +99,15 @@ export default <template>(if(eq setting.type "enum")"select"- (if (eq setting.type "list") "custom" "input")+ (if+ (or+ (eq setting.type "category_list")+ (eq setting.type "group_list")+ (eq setting.type "list")+ )+ "custom"+ "input"+ )))}}diff --git a/plugins/discourse-ai/spec/system/admin_ai_features_spec.rb b/plugins/discourse-ai/spec/system/admin_ai_features_spec.rbindex 6bd1fbf755b..1178dcf1f74 100644--- a/plugins/discourse-ai/spec/system/admin_ai_features_spec.rb+++ b/plugins/discourse-ai/spec/system/admin_ai_features_spec.rb@@ -74,6 +74,22 @@ RSpec.describe "Admin AI features configuration" doexpect(page).to have_css(".form-kit__field")end+ it "renders group_list settings as group selectors" do+ SiteSetting.ai_bot_enabled = true+ SiteSetting.ai_bot_allowed_groups = "#{group_1.id}|#{group_2.id}"++ page.visit(+ "/admin/plugins/discourse-ai/ai-features/#{DiscourseAi::Configuration::Module::BOT_ID}/edit",+ )++ expect(page).to have_css(".ai-feature-editor")++ field = form.field("ai_bot_allowed_groups")+ expect(field.component).to have_css(".list-setting")+ expect(field.component).to have_content(group_1.name)+ expect(field.component).to have_content(group_2.name)+ end+it "displays LLM names in compact_list settings" dollm1 = Fabricate(:llm_model, display_name: "Test LLM Alpha")llm2 = Fabricate(:llm_model, display_name: "Test LLM Beta")