Skip to content

A platform for community discussion. Free, open, simple.

FIX: Navigate away from bot PM when clicking `/new-topic` with docked composer active (#41133)

Keegan George5c507d8359f4
diff --git a/frontend/discourse/app/routes/new-topic.js b/frontend/discourse/app/routes/new-topic.js
index 114c806c745..21b3a070d18 100644
--- a/frontend/discourse/app/routes/new-topic.js
+++ b/frontend/discourse/app/routes/new-topic.js
@@ -33,8 +33,13 @@ export default class extends DiscourseRoute {
return;
}
- // When navigating from another ember route
- if (transition.from) {
+ // When navigating from another Ember route, open the composer in-place —
+ // unless a docked composer is active, in which case #reply-control is hidden
+ // and aborting the transition corrupts the layout.
+ if (
+ transition.from &&
+ !document.body.classList.contains("has-ai-bot-docked-composer")
+ ) {
transition.abort();
this.#openComposer(params);
return;
diff --git a/plugins/discourse-ai/spec/system/ai_bot/docked_composer_spec.rb b/plugins/discourse-ai/spec/system/ai_bot/docked_composer_spec.rb
index c8e42592cd4..999db752a7a 100644
--- a/plugins/discourse-ai/spec/system/ai_bot/docked_composer_spec.rb
+++ b/plugins/discourse-ai/spec/system/ai_bot/docked_composer_spec.rb
@@ -37,6 +37,15 @@ RSpec.describe "AI Bot docked composer" do
fab!(:first_post) { Fabricate(:post, topic: pm, user: user, post_number: 1, raw: "Hello bot") }
fab!(:bot_post) { Fabricate(:post, topic: pm, user: bot_user, post_number: 2, raw: "Hello user") }
+ fab!(:bot_post_with_new_topic_link) do
+ Fabricate(
+ :post,
+ topic: pm,
+ user: bot_user,
+ post_number: 3,
+ raw: "Need more help? [Click here to ask a question](/new-topic) in the forum.",
+ )
+ end
fab!(:regular_topic) { Fabricate(:topic, user: user) }
fab!(:regular_post) { Fabricate(:post, topic: regular_topic, user: user, raw: "Regular topic") }
@@ -143,4 +152,19 @@ RSpec.describe "AI Bot docked composer" do
expect(page).to have_no_css(".ai-bot-docked-composer")
expect(page).to have_css("#topic-footer-buttons .create")
end
+
+ it "navigates away to the homepage and opens the new-topic composer when a /new-topic link is clicked" do
+ topic_page.visit_topic(pm)
+ expect(page).to have_css(".ai-bot-docked-composer")
+
+ find(
+ "article[data-post-id='#{bot_post_with_new_topic_link.id}'] .cooked a[href='/new-topic']",
+ ).click
+
+ expect(page).to have_current_path("/latest", ignore_query: true)
+ expect(page).to have_no_css("body.has-ai-bot-docked-composer")
+
+ composer = PageObjects::Components::Composer.new
+ expect(composer).to be_opened
+ end
end