A platform for community discussion. Free, open, simple.
SECURITY: prevent hidden profile data leak via user onebox
Joffrey JAFFEUX5eca5b58aab0
diff --git a/lib/oneboxer.rb b/lib/oneboxer.rbindex 3bebb780f6c..e8c4dda278e 100644--- a/lib/oneboxer.rb+++ b/lib/oneboxer.rb@@ -418,6 +418,7 @@ module Oneboxerusername = route[:username] || ""if user = User.find_by(username_lower: username.downcase)+ return if SiteSetting.allow_users_to_hide_profile && user.user_option&.hide_profile?name = user.name if SiteSetting.enable_namesargs = {diff --git a/spec/requests/onebox_controller_spec.rb b/spec/requests/onebox_controller_spec.rbindex 7119541008a..70124f7566b 100644--- a/spec/requests/onebox_controller_spec.rb+++ b/spec/requests/onebox_controller_spec.rb@@ -208,5 +208,40 @@ RSpec.describe OneboxController doexpect(response.body).not_to include("aside")endend++ context "with local user profiles" do+ fab!(:hidden_user, :user)++ before do+ hidden_user.user_profile.update!(+ bio_raw: "secret bio content",+ location: "secret location",+ website: "https://secret.example.com",+ )+ SiteSetting.allow_users_to_hide_profile = true+ hidden_user.user_option.update!(hide_profile: true)+ end++ it "does not onebox a hidden user profile" do+ url = "#{Discourse.base_url}/u/#{hidden_user.username}"++ get "/onebox.json", params: { url: url }++ expect(response.body).not_to include("secret bio content")+ expect(response.body).not_to include("secret location")+ expect(response.body).not_to include("secret.example.com")+ end++ it "oneboxes a user profile when the viewer can see the profile" do+ visible_user = Fabricate(:user)+ visible_user.user_profile.update!(location: "visible location")+ url = "#{Discourse.base_url}/u/#{visible_user.username}"++ get "/onebox.json", params: { url: url }++ expect(response.body).to include(visible_user.username)+ expect(response.body).to include("visible location")+ end+ endendend