Skip to content

A platform for community discussion. Free, open, simple.

DEV: Allow custom errors for bot setting changes (#44661)

Gabriel Grubba60cbc8e4e4e5
diff --git a/plugins/discourse-ai/lib/agents/tools/change_site_setting.rb b/plugins/discourse-ai/lib/agents/tools/change_site_setting.rb
index 220e054f503..5cdd6c63e21 100644
--- a/plugins/discourse-ai/lib/agents/tools/change_site_setting.rb
+++ b/plugins/discourse-ai/lib/agents/tools/change_site_setting.rb
@@ -184,6 +184,16 @@ module DiscourseAi
)
end
+ error =
+ DiscoursePluginRegistry.apply_modifier(
+ :ai_bot_site_setting_change_error,
+ nil,
+ setting_sym,
+ new_value,
+ guardian,
+ )
+ return error_response(error) if error.present?
+
nil
end
diff --git a/plugins/discourse-ai/spec/lib/agents/tools/change_site_setting_spec.rb b/plugins/discourse-ai/spec/lib/agents/tools/change_site_setting_spec.rb
index 8cef725382d..8f06ccd3ca2 100644
--- a/plugins/discourse-ai/spec/lib/agents/tools/change_site_setting_spec.rb
+++ b/plugins/discourse-ai/spec/lib/agents/tools/change_site_setting_spec.rb
@@ -164,6 +164,34 @@ RSpec.describe DiscourseAi::Agents::Tools::ChangeSiteSetting do
end
describe "#validation_error" do
+ it "returns a plugin rejection with the setting, proposed value, and acting user" do
+ plugin = Plugin::Instance.new
+ modifier =
+ proc do |error, setting_name, value, guardian|
+ error || "#{setting_name}=#{value} is restricted for #{guardian.user.username}"
+ end
+ plugin.register_modifier(:ai_bot_site_setting_change_error, &modifier)
+
+ setting_tool = tool(setting_name: "min_post_length", value: "42", reason: "Test")
+ expected_error = {
+ status: "error",
+ error: "min_post_length=42 is restricted for #{bot_user.username}",
+ }
+
+ expect {
+ expect(setting_tool.validation_error).to eq(expected_error)
+ expect(setting_tool.invoke).to eq(expected_error)
+ }.to not_change { SiteSetting.min_post_length }.and not_change {
+ UserHistory.where(action: UserHistory.actions[:change_site_setting]).count
+ }
+ ensure
+ DiscoursePluginRegistry.unregister_modifier(
+ plugin,
+ :ai_bot_site_setting_change_error,
+ &modifier
+ )
+ end
+
it "returns nil for a valid request without changing the setting" do
t = tool(setting_name: "min_post_length", value: "42", reason: "Test")