Skip to content

A platform for community discussion. Free, open, simple.

UX: always show toolbar when composer redesign is enabled (#44641)

Kris630a339d3bd6
diff --git a/frontend/discourse/app/services/composer.js b/frontend/discourse/app/services/composer.js
index d719b7477ba..30fe6de398a 100644
--- a/frontend/discourse/app/services/composer.js
+++ b/frontend/discourse/app/services/composer.js
@@ -249,6 +249,12 @@ export default class ComposerService extends Service {
@computed
get showToolbar() {
+ // The redesign has no toolbar toggle, so a preference stored by the legacy
+ // composer would hide the toolbar with no way to restore it.
+ if (this.siteSettings.enable_composer_redesign) {
+ return true;
+ }
+
return (
this._toolbarEnabled ??
this.keyValueStore.get("toolbar-enabled") !== "false"
diff --git a/spec/system/composer/redesign_spec.rb b/spec/system/composer/redesign_spec.rb
index b433ac17e71..ea8543063e9 100644
--- a/spec/system/composer/redesign_spec.rb
+++ b/spec/system/composer/redesign_spec.rb
@@ -52,6 +52,16 @@ describe "Composer redesign" do
expect(composer).to have_pm_recipients_in_category_row
expect(composer).to have_title_below_category_row
end
+
+ it "shows the toolbar even if the user hid it in the legacy composer", mobile: true do
+ visit("/")
+ page.execute_script("window.localStorage.setItem('discourse_toolbar-enabled', 'false');")
+
+ visit("/new-topic")
+
+ expect(composer).to be_opened
+ expect(composer).to have_footer_toolbar
+ end
end
context "when enable_composer_redesign is disabled" do