A platform for community discussion. Free, open, simple.
FIX: Emit topic_created when splitting posts into a new topic
Jake Goldsborough6697456a06ce
diff --git a/app/models/post_mover.rb b/app/models/post_mover.rbindex 2e86aa9214e..6c5d9077a1f 100644--- a/app/models/post_mover.rb+++ b/app/models/post_mover.rb@@ -82,6 +82,7 @@ class PostMovernew_topicendenqueue_jobs(topic)+ DiscourseEvent.trigger(:topic_created, topic, @options, user, continue_on_error: true)topicenddiff --git a/spec/models/post_mover_spec.rb b/spec/models/post_mover_spec.rbindex 039ac3c711b..eb185e088f0 100644--- a/spec/models/post_mover_spec.rb+++ b/spec/models/post_mover_spec.rb@@ -32,6 +32,15 @@ RSpec.describe PostMover doend.not_to change { [Post.count, reply.reload.topic_id, topic.reload.closed] }end+ it "does not emit topic_created when moving to an existing topic" do+ mover = described_class.new(topic, admin, [reply.id])++ events = DiscourseEvent.track_events(:topic_created) { mover.to_topic(destination_topic.id) }++ expect(events).to be_empty+ expect(reply.reload.topic_id).to eq(destination_topic.id)+ end+it "rejects the move when no destination is given" domover = described_class.new(topic, admin, [reply.id])@@ -45,6 +54,33 @@ RSpec.describe PostMover dofab!(:first_post) { Fabricate(:post, topic: topic) }fab!(:reply) { Fabricate(:post, topic: topic) }+ it "emits topic_created once for the completed split" do+ mover = described_class.new(topic, admin, [reply.id])+ destination = nil++ events =+ DiscourseEvent.track_events(:topic_created) do+ destination = mover.to_new_topic("A separate discussion")+ end++ expect(events.size).to eq(1)+ expect(events.first[:params]).to eq([destination, {}, admin, { continue_on_error: true }])+ expect(destination.first_post).to eq(reply.reload)+ expect(destination.excerpt).to be_present+ end++ it "does not emit topic_created when creating the destination fails" do+ mover = described_class.new(topic, admin, [reply.id])++ events =+ DiscourseEvent.track_events(:topic_created) do+ expect { mover.to_new_topic("") }.to raise_error(ActiveRecord::RecordInvalid)+ end++ expect(events).to be_empty+ expect(reply.reload.topic_id).to eq(topic.id)+ end+it "does not create a topic when the user cannot move posts from the source topic" domover = described_class.new(topic, Fabricate(:user), [reply.id])