Skip to content

A platform for community discussion. Free, open, simple.

DEV: Require login and confirmed session for update_security_key (#38644)

Isaac Janzen66cd07da1b86
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index ccddf6e16d8..ae56e54b112 100644
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -30,6 +30,7 @@ class UsersController < ApplicationController
register_passkey
rename_passkey
delete_passkey
+ update_security_key
feature_topic
clear_featured_topic
bookmarks
@@ -83,8 +84,8 @@ class UsersController < ApplicationController
create_second_factor_security_key
register_passkey
delete_passkey
+ update_security_key
]
-
before_action :respond_to_suspicious_request, only: [:create]
# we need to allow account creation with bad CSRF tokens, if people are caching, the CSRF token on the
diff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rb
index 764bcb0c1dc..6c17452c37b 100644
--- a/spec/requests/users_controller_spec.rb
+++ b/spec/requests/users_controller_spec.rb
@@ -6627,6 +6627,52 @@ RSpec.describe UsersController do
end
end
+ describe "#update_security_key" do
+ fab!(:security_key) { Fabricate(:user_security_key_with_random_credential, user: user1) }
+
+ it "fails if user is not logged in" do
+ put "/u/security_key.json", params: { id: security_key.id, disable: "true" }
+ expect(response.status).to eq(403)
+ end
+
+ it "fails if user does not have a confirmed session" do
+ sign_in(user1)
+ put "/u/security_key.json", params: { id: security_key.id, disable: "true" }
+ expect(response.status).to eq(403)
+ end
+
+ context "with a confirmed session" do
+ before do
+ stub_server_session_confirmed
+ sign_in(user1)
+ end
+
+ it "returns 400 for an invalid security key id" do
+ put "/u/security_key.json", params: { id: 0, disable: "true" }
+ expect(response.status).to eq(400)
+ end
+
+ it "does not allow modifying another user's security key" do
+ sign_in(admin)
+ put "/u/security_key.json", params: { id: security_key.id, name: "hacked" }
+ expect(response.status).to eq(400)
+ expect(security_key.reload.name).not_to eq("hacked")
+ end
+
+ it "disables the security key" do
+ put "/u/security_key.json", params: { id: security_key.id, disable: "true" }
+ expect(response.status).to eq(200)
+ expect(security_key.reload.enabled).to eq(false)
+ end
+
+ it "renames the security key" do
+ put "/u/security_key.json", params: { id: security_key.id, name: "new name" }
+ expect(response.status).to eq(200)
+ expect(security_key.reload.name).to eq("new name")
+ end
+ end
+ end
+
describe "#register_passkey" do
before do
SiteSetting.enable_passkeys = true