Skip to content

A platform for community discussion. Free, open, simple.

PERF: Skip review page preloads in the user menu reviewables tab

Régis Hanol68a51528e031
diff --git a/app/models/reviewable.rb b/app/models/reviewable.rb
index 1dfd2dce4a4..a0b8e2a5038 100644
--- a/app/models/reviewable.rb
+++ b/app/models/reviewable.rb
@@ -789,7 +789,7 @@ class Reviewable < ActiveRecord::Base
end
def self.user_menu_list_for(user, limit: 30)
- list_for(user, limit: limit, status: :pending, include_claimed_by_others: false).to_a
+ list_for(user, limit:, status: :pending, include_claimed_by_others: false, preload: false).to_a
end
def self.basic_serializers_for_list(reviewables, user)
diff --git a/spec/requests/reviewables_controller_spec.rb b/spec/requests/reviewables_controller_spec.rb
index 0ba1d1d337e..5ca96d966a8 100644
--- a/spec/requests/reviewables_controller_spec.rb
+++ b/spec/requests/reviewables_controller_spec.rb
@@ -582,8 +582,9 @@ RSpec.describe ReviewablesController do
reviewable_flagged_post = Fabricate(:reviewable_flagged_post)
reviewable_queued_post = Fabricate(:reviewable_queued_post)
- get "/review/user-menu-list.json"
+ queries = track_sql_queries { get "/review/user-menu-list.json" }
expect(response.status).to eq(200)
+ expect(queries.grep(/FROM "reviewable_(scores|notes|histories)"/)).to be_empty
reviewables = response.parsed_body["reviewables"]