A platform for community discussion. Free, open, simple.
FIX: guard against missing user or topic in spam scanner (#45429)
ducks693809d7356e
diff --git a/plugins/discourse-ai/lib/ai_moderation/spam_scanner.rb b/plugins/discourse-ai/lib/ai_moderation/spam_scanner.rbindex 2670e6aa03a..4b7d4b3c781 100644--- a/plugins/discourse-ai/lib/ai_moderation/spam_scanner.rb+++ b/plugins/discourse-ai/lib/ai_moderation/spam_scanner.rb@@ -113,6 +113,9 @@ module DiscourseAidef self.should_scan_post?(post)return false if !post.present?+ # user or topic may be gone by the time the scan job runs (deletion+ # race); skip instead of raising through the job's rescue and requeue+ return false if !post.user || !post.topicreturn false if post.user.trust_level > SiteSetting.ai_spam_detection_max_trust_levelreturn false if post.topic.private_message?return false if post.user.bot?diff --git a/plugins/discourse-ai/spec/lib/modules/ai_moderation/spam_scanner_spec.rb b/plugins/discourse-ai/spec/lib/modules/ai_moderation/spam_scanner_spec.rbindex 89deb2e5f8f..a823a698a52 100644--- a/plugins/discourse-ai/spec/lib/modules/ai_moderation/spam_scanner_spec.rb+++ b/plugins/discourse-ai/spec/lib/modules/ai_moderation/spam_scanner_spec.rb@@ -113,6 +113,18 @@ RSpec.describe DiscourseAi::AiModeration::SpamScanner doit "returns false for nil posts" doexpect(described_class.should_scan_post?(nil)).to eq(false)end++ it "returns false for posts with a missing user" do+ post.association(:user).target = nil+ post.association(:user).loaded!+ expect(described_class.should_scan_post?(post)).to eq(false)+ end++ it "returns false for posts with a missing topic" do+ post.association(:topic).target = nil+ post.association(:topic).loaded!+ expect(described_class.should_scan_post?(post)).to eq(false)+ endenddescribe ".perform_scan" do