Skip to content

A platform for community discussion. Free, open, simple.

DEV: Fix stale element race condition in templates panel page object (#38444)

Isaac Janzen6a17f541b86b
diff --git a/plugins/discourse-templates/spec/system/page_objects/components/d_templates_panel.rb b/plugins/discourse-templates/spec/system/page_objects/components/d_templates_panel.rb
index b4bcb1f4d03..6efd11dbb06 100644
--- a/plugins/discourse-templates/spec/system/page_objects/components/d_templates_panel.rb
+++ b/plugins/discourse-templates/spec/system/page_objects/components/d_templates_panel.rb
@@ -16,12 +16,8 @@ module PageObjects
end
def has_templates?(*templates)
- templates.all? { |template| has_css?("#template-item-#{template.id}") } &&
- template_count == templates.size
- end
-
- def template_count
- all("#{PANEL_SELECTOR} .template-item").count
+ has_css?("#{PANEL_SELECTOR} .template-item", count: templates.size) &&
+ templates.all? { |template| has_css?("#template-item-#{template.id}") }
end
end
end