A platform for community discussion. Free, open, simple.
FIX: Moved reviewable post content leaks to old category moderators (#41041)
Juan David Martínez Cubillos6cb5fe9760af
diff --git a/app/models/post_mover.rb b/app/models/post_mover.rbindex 12de911cd16..885a084101e 100644--- a/app/models/post_mover.rb+++ b/app/models/post_mover.rb@@ -145,6 +145,7 @@ class PostMoverupdate_last_post_statsupdate_upload_security_statusupdate_bookmarks+ update_reviewablesclose_topic_and_schedule_deletion if @full_move@@ -753,6 +754,13 @@ class PostMoverendend+ def update_reviewables+ Reviewable.where(target_type: "Post", target_id: @post_ids).update_all(+ topic_id: @destination_topic.id,+ category_id: @destination_topic.category_id,+ )+ end+def watch_new_topicif @destination_topic.archetype == Archetype.private_messageif @original_topic.archetype == Archetype.private_messagediff --git a/spec/models/post_mover_spec.rb b/spec/models/post_mover_spec.rbindex be6fe40516f..f1eee97ae40 100644--- a/spec/models/post_mover_spec.rb+++ b/spec/models/post_mover_spec.rb@@ -3448,6 +3448,60 @@ RSpec.describe PostMover doendend+ context "with reviewables" do+ fab!(:original_category, :category)+ fab!(:original_topic) { Fabricate(:topic, category: original_category) }+ fab!(:target_post) { Fabricate(:post, topic: original_topic) }++ fab!(:private_category) { Fabricate(:private_category, group: Fabricate(:group)) }+ fab!(:private_topic) { Fabricate(:topic, category: private_category) }++ fab!(:reviewable) do+ Fabricate(+ :reviewable_flagged_post,+ target: target_post,+ target_created_by: target_post.user,+ topic: original_topic,+ category: original_category,+ )+ end++ it "updates reviewable category_id and topic_id when moving posts to another topic" do+ expect(reviewable.category_id).to eq(original_category.id)+ expect(reviewable.topic_id).to eq(original_topic.id)++ PostMover.new(original_topic, admin, [target_post.id]).to_topic(private_topic.id)++ reviewable.reload+ expect(reviewable.category_id).to eq(private_category.id)+ expect(reviewable.topic_id).to eq(private_topic.id)+ end++ it "updates multiple reviewables when moving multiple flagged posts" do+ target_post_2 = Fabricate(:post, topic: original_topic)+ reviewable_2 =+ Fabricate(+ :reviewable_flagged_post,+ target: target_post_2,+ target_created_by: target_post_2.user,+ topic: original_topic,+ category: original_category,+ )++ PostMover.new(original_topic, admin, [target_post.id, target_post_2.id]).to_topic(+ private_topic.id,+ )++ reviewable.reload+ reviewable_2.reload++ expect(reviewable.category_id).to eq(private_category.id)+ expect(reviewable.topic_id).to eq(private_topic.id)+ expect(reviewable_2.category_id).to eq(private_category.id)+ expect(reviewable_2.topic_id).to eq(private_topic.id)+ end+ end+def create_post_timing(post, user, msecs)PostTiming.create!(topic_id: post.topic_id,