A platform for community discussion. Free, open, simple.
DEV: Add tests for intentional granular API key behavior for /about (#39922)
Isaac Janzen6d27e65d7df7
diff --git a/spec/models/api_key_scope_spec.rb b/spec/models/api_key_scope_spec.rbindex 2f099c445af..f6a917e93a2 100644--- a/spec/models/api_key_scope_spec.rb+++ b/spec/models/api_key_scope_spec.rb@@ -15,4 +15,10 @@ RSpec.describe ApiKeyScope do)endend++ describe ".scope_mappings" do+ it "does not define a granular scope for about requests" do+ expect(described_class.scope_mappings).not_to have_key(:about)+ end+ endenddiff --git a/spec/requests/about_controller_spec.rb b/spec/requests/about_controller_spec.rbindex 243903a0598..2ed415c0289 100644--- a/spec/requests/about_controller_spec.rb+++ b/spec/requests/about_controller_spec.rb@@ -64,6 +64,30 @@ RSpec.describe AboutController doexpect(response.parsed_body["about"].keys).not_to include("stats")end+ context "with a granular API key" do+ fab!(:admin)+ fab!(:user)+ fab!(:api_key, refind: false) do+ Fabricate(+ :api_key,+ api_key_scopes: [Fabricate.build(:api_key_scope, resource: "about", action: "read")],+ )+ end++ before do+ SiteSetting.hide_user_profiles_from_public = true+ SiteSetting.login_required = true+ end++ it "uses the supplied API username for about requests" do+ get "/about.json", headers: { "Api-Key": api_key.key, "Api-Username": user.username }++ expect(response.status).to eq(200)+ expect(response.parsed_body.dig("about", "title")).to eq(SiteSetting.title)+ expect(response.parsed_body.dig("about", "admin_ids") || []).to include(admin.id)+ end+ end+context "with profile visibility controls" dofab!(:admin)fab!(:moderator)