Skip to content

A platform for community discussion. Free, open, simple.

UX: Prevent wide tables from breaking the dashboard (#41648)

Krzysztof Kotlarek70cdb7885aa8
diff --git a/app/assets/stylesheets/admin/admin_dashboard.scss b/app/assets/stylesheets/admin/admin_dashboard.scss
index d52b50f51d9..24b1a8428e5 100644
--- a/app/assets/stylesheets/admin/admin_dashboard.scss
+++ b/app/assets/stylesheets/admin/admin_dashboard.scss
@@ -435,11 +435,11 @@ $db-bar-height: var(--space-2);
&.--grid {
display: grid;
- grid-template-columns: 1fr 1fr;
+ grid-template-columns: repeat(2, minmax(0, 1fr));
gap: var(--space-4);
@include viewport.until(sm) {
- grid-template-columns: 1fr;
+ grid-template-columns: minmax(0, 1fr);
}
}
diff --git a/plugins/discourse-data-explorer/assets/javascripts/discourse/components/admin-dashboard-card.gjs b/plugins/discourse-data-explorer/assets/javascripts/discourse/components/admin-dashboard-card.gjs
index e22f51091f0..583becfa56a 100644
--- a/plugins/discourse-data-explorer/assets/javascripts/discourse/components/admin-dashboard-card.gjs
+++ b/plugins/discourse-data-explorer/assets/javascripts/discourse/components/admin-dashboard-card.gjs
@@ -12,6 +12,10 @@ export default class DataExplorerAdminDashboardCard extends Component {
return this.args.payload?.columns ?? [];
}
+ get columnLabels() {
+ return this.columns.map((col) => col.replaceAll("_", " "));
+ }
+
get chartability() {
return chartability(this.args.payload);
}
@@ -41,7 +45,7 @@ export default class DataExplorerAdminDashboardCard extends Component {
get chartDatasets() {
return this.chartability.numericIndices.map((colIdx) => ({
- label: this.columns[colIdx],
+ label: this.columnLabels[colIdx],
values: this.rows.map((row) => Number(row[colIdx])),
}));
}
@@ -60,7 +64,7 @@ export default class DataExplorerAdminDashboardCard extends Component {
<table class="de-dashboard-card__table">
<thead>
<tr>
- {{#each this.columns as |col|}}
+ {{#each this.columnLabels as |col|}}
<th>{{col}}</th>
{{/each}}
</tr>