A platform for community discussion. Free, open, simple.
SECURITY: Prevent moderators from exporting admin-only reports via CSV
Isaac Janzen727029a2983a
diff --git a/app/controllers/export_csv_controller.rb b/app/controllers/export_csv_controller.rbindex c412a64f647..6ba212b7d5d 100644--- a/app/controllers/export_csv_controller.rb+++ b/app/controllers/export_csv_controller.rb@@ -7,7 +7,7 @@ class ExportCsvController < ApplicationControllerdef export_entityentity = export_params[:entity]entity_id = params.dig(:args, :export_user_id)&.to_i if entity == "user_archive"- guardian.ensure_can_export_entity!(entity, entity_id)+ guardian.ensure_can_export_entity!(entity, entity_id, export_params[:args])raise Discourse::InvalidParameters.new(:entity) unless entity.is_a?(String) && entity.size < 100(export_params[:args] || {}).each do |key, value|diff --git a/lib/guardian.rb b/lib/guardian.rbindex 05dfd62dff9..a048d610221 100644--- a/lib/guardian.rb+++ b/lib/guardian.rb@@ -485,13 +485,18 @@ class Guardian@user.in_any_groups?(SiteSetting.send_email_messages_allowed_groups_map)end- def can_export_entity?(entity, entity_id = nil)+ def can_export_entity?(entity, entity_id = nil, args = nil)return false if anonymous?return true if is_admin?return can_see_emails? if entity == "screened_email"return can_see_ip? if entity == "screened_ip"if is_moderator? && (entity != "user_archive" || entity_id.nil?)+ if entity == "report"+ report_name = args&.[](:name) || args&.[]("name")+ return true if report_name.blank?+ return !Report.hidden?(report_name, admin: false)+ endreturn %w[staff_action screened_url report user_archive].include?(entity)enddiff --git a/spec/lib/guardian_spec.rb b/spec/lib/guardian_spec.rbindex 02a607bbd7a..41d53989379 100644--- a/spec/lib/guardian_spec.rb+++ b/spec/lib/guardian_spec.rb@@ -2518,6 +2518,14 @@ RSpec.describe Guardian doexpect(moderator_guardian.can_export_entity?("screened_ip")).to be_truthyend+ it "only allows admins to export admin-only reports" do+ expect(user_guardian.can_export_entity?("report", nil, { name: "top_uploads" })).to be_falsey+ expect(+ moderator_guardian.can_export_entity?("report", nil, { name: "top_uploads" }),+ ).to be_falsey+ expect(admin_guardian.can_export_entity?("report", nil, { name: "top_uploads" })).to be_truthy+ end+it "does not allow anonymous to export" doexpect(anonymous_guardian.can_export_entity?("user_archive")).to be_falseyenddiff --git a/spec/requests/export_csv_controller_spec.rb b/spec/requests/export_csv_controller_spec.rbindex 065952dcc1a..eca3e7ae917 100644--- a/spec/requests/export_csv_controller_spec.rb+++ b/spec/requests/export_csv_controller_spec.rb@@ -208,6 +208,34 @@ RSpec.describe ExportCsvController doexpect(job_data["entity"]).to eq("staff_action")expect(job_data["user_id"]).to eq(moderator.id)end++ it "does not allow moderators to export admin-only reports" do+ post "/export_csv/export_entity.json",+ params: {+ entity: "report",+ args: {+ name: "top_uploads",+ start_date: "2026-01-01",+ end_date: "2026-02-15",+ },+ }+ expect(response.status).to eq(422)+ expect(Jobs::ExportCsvFile.jobs.size).to eq(0)+ end++ it "allows moderators to export non-hidden reports" do+ post "/export_csv/export_entity.json",+ params: {+ entity: "report",+ args: {+ name: "likes",+ start_date: "2026-01-01",+ end_date: "2026-02-15",+ },+ }+ expect(response.status).to eq(200)+ expect(Jobs::ExportCsvFile.jobs.size).to eq(1)+ endenddescribe "#latest_user_archive" do