Skip to content

A platform for community discussion. Free, open, simple.

FEATURE: Allow /filter on topic_ids (#42900)

Natalie Tay73585011d743
diff --git a/app/controllers/list_controller.rb b/app/controllers/list_controller.rb
index b4216f9140d..73ce35ef48b 100644
--- a/app/controllers/list_controller.rb
+++ b/app/controllers/list_controller.rb
@@ -132,7 +132,7 @@ class ListController < ApplicationController
def filter
topic_query_opts = { no_definitions: !SiteSetting.show_category_definitions_in_topic_lists }
- %i[page q].each do |key|
+ %i[page q topic_ids].each do |key|
if params.key?(key.to_s)
value = params[key]
raise Discourse::InvalidParameters.new(key) if !TopicQuery.validate?(key, value)
@@ -140,6 +140,8 @@ class ListController < ApplicationController
end
end
+ topic_query_opts[:topic_ids] = param_to_integer_list(:topic_ids) if params.key?(:topic_ids)
+
user = current_user
list = TopicQuery.new(user, topic_query_opts).list_filter
list.more_topics_url = construct_url_with(:next, topic_query_opts)
diff --git a/spec/requests/list_controller_spec.rb b/spec/requests/list_controller_spec.rb
index 01bb0d60ba1..704f38d459b 100644
--- a/spec/requests/list_controller_spec.rb
+++ b/spec/requests/list_controller_spec.rb
@@ -1842,6 +1842,17 @@ RSpec.describe ListController do
end
end
+ it "allows users to filter on a set of topic ids" do
+ topic_2 = Fabricate(:topic)
+
+ get "/filter.json", params: { topic_ids: topic_2.id.to_s }
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body["topic_list"]["topics"].map { |topic| topic["id"] }).to eq(
+ [topic_2.id],
+ )
+ end
+
it "keeps query params encoded in more_topics_url when unicode usernames are enabled" do
SiteSetting.unicode_usernames = true