A platform for community discussion. Free, open, simple.
FIX: Disagreeing with a flag fails to restore posts by demoted users (#40228)
Régis Hanol741afab95f49
diff --git a/app/models/reviewable_flagged_post.rb b/app/models/reviewable_flagged_post.rbindex c828082c8e6..a3d8903b2e6 100644--- a/app/models/reviewable_flagged_post.rb+++ b/app/models/reviewable_flagged_post.rb@@ -242,6 +242,7 @@ class ReviewableFlaggedPost < Reviewable# Undo hide/silence if applicableif post&.hidden?notify_poster(performed_by)+ post.acting_user = performed_bypost.unhide!UserSilencer.unsilence(post.user) if UserSilencer.was_silenced_for?(post)enddiff --git a/spec/models/reviewable_flagged_post_spec.rb b/spec/models/reviewable_flagged_post_spec.rbindex 18c4fdd2897..1f7652e7dfd 100644--- a/spec/models/reviewable_flagged_post_spec.rb+++ b/spec/models/reviewable_flagged_post_spec.rb@@ -496,6 +496,27 @@ RSpec.describe ReviewableFlaggedPost, type: :model doendend+ describe "#perform_disagree" do+ it "restores a hidden post even when the author would no longer pass post validations" do+ SiteSetting.newuser_max_embedded_media = 1++ author = Fabricate(:user, trust_level: TrustLevel[1], refresh_auto_groups: true)+ flagged_post =+ create_post(+ user: author,+ raw: "\n",+ )+ reviewable = PostActionCreator.spam(user, flagged_post).reviewable+ flagged_post.hide!(PostActionType.types[:spam])++ author.update!(trust_level: TrustLevel[0])++ expect { reviewable.perform(moderator, :disagree) }.not_to raise_error+ expect(flagged_post.reload.hidden).to eq(false)+ expect(flagged_post.topic.reload.visible).to eq(true)+ end+ end+describe "#perform_disagree_and_restore" doit "notifies the user about the flagged post being restored" doreviewable = Fabricate(:reviewable_flagged_post)