A platform for community discussion. Free, open, simple.
PERF: Drop four unused indexes on browser pageview events (#44109)
Osama Sayegh7589692c8d31
diff --git a/app/models/browser_pageview_event.rb b/app/models/browser_pageview_event.rbindex e3bf61e85d2..77d5c93e77b 100644--- a/app/models/browser_pageview_event.rb+++ b/app/models/browser_pageview_event.rb@@ -276,15 +276,11 @@ end## idx_bpe_browser_backfill (created_at DESC,id DESC) WHERE (browser IS NULL)# idx_bpe_crawler_created_at_covering (created_at) WHERE (score > 55)-# idx_bpe_created_at_country_code (created_at,country_code)# idx_bpe_created_at_id (created_at DESC,id DESC)-# idx_bpe_created_at_normalized_referrer (created_at,normalized_referrer)# idx_bpe_created_at_session_id (created_at,session_id,source)# idx_bpe_ip_created_at (ip_address,created_at)# idx_bpe_referrer_backfill (created_at DESC,id DESC) WHERE ((referrer IS NOT NULL) AND ((normalized_referrer_version IS NULL) OR (normalized_referrer_version < 1)))# idx_bpe_session_created_at_covering (session_id,created_at)# idx_bpe_url_backfill (created_at DESC,id DESC) WHERE ((normalized_url_version IS NULL) OR (normalized_url_version < 1))# index_browser_pageview_events_on_created_at (created_at) USING brin-# index_browser_pageview_events_on_topic_id (topic_id)-# index_browser_pageview_events_on_user_id (user_id)#diff --git a/db/post_migrate/20260925054715_drop_unused_browser_pageview_indexes.rb b/db/post_migrate/20260925054715_drop_unused_browser_pageview_indexes.rbnew file mode 100644index 00000000000..8c0ce9d8abc--- /dev/null+++ b/db/post_migrate/20260925054715_drop_unused_browser_pageview_indexes.rb@@ -0,0 +1,29 @@+# frozen_string_literal: true++class DropUnusedBrowserPageviewIndexes < ActiveRecord::Migration[8.0]+ disable_ddl_transaction!++ def up+ %w[+ idx_bpe_created_at_country_code+ idx_bpe_created_at_normalized_referrer+ index_browser_pageview_events_on_user_id+ index_browser_pageview_events_on_topic_id+ ].each do |name|+ remove_index :browser_pageview_events, name: name, algorithm: :concurrently, if_exists: true+ end+ end++ def down+ add_index :browser_pageview_events,+ %i[created_at country_code],+ name: "idx_bpe_created_at_country_code",+ algorithm: :concurrently+ add_index :browser_pageview_events,+ %i[created_at normalized_referrer],+ name: "idx_bpe_created_at_normalized_referrer",+ algorithm: :concurrently+ add_index :browser_pageview_events, :user_id, algorithm: :concurrently+ add_index :browser_pageview_events, :topic_id, algorithm: :concurrently+ end+enddiff --git a/db/structure.sql b/db/structure.sqlindex ced344e628b..c486002778e 100644--- a/db/structure.sql+++ b/db/structure.sql@@ -19359,13 +19359,6 @@ CREATE INDEX idx_bpe_browser_backfill ON public.browser_pageview_events USING btCREATE INDEX idx_bpe_crawler_created_at_covering ON public.browser_pageview_events USING btree (created_at) INCLUDE (topic_id, user_id, ip_address) WHERE (score > 55);------ Name: idx_bpe_created_at_country_code; Type: INDEX; Schema: public; Owner: ------CREATE INDEX idx_bpe_created_at_country_code ON public.browser_pageview_events USING btree (created_at, country_code);------ Name: idx_bpe_created_at_id; Type: INDEX; Schema: public; Owner: ---@@ -19373,13 +19366,6 @@ CREATE INDEX idx_bpe_created_at_country_code ON public.browser_pageview_events UCREATE INDEX idx_bpe_created_at_id ON public.browser_pageview_events USING btree (created_at DESC, id DESC);------ Name: idx_bpe_created_at_normalized_referrer; Type: INDEX; Schema: public; Owner: ------CREATE INDEX idx_bpe_created_at_normalized_referrer ON public.browser_pageview_events USING btree (created_at, normalized_referrer);------ Name: idx_bpe_created_at_session_id; Type: INDEX; Schema: public; Owner: ---@@ -20885,20 +20871,6 @@ CREATE UNIQUE INDEX index_browser_pageview_event_scores_on_event_id ON public.brCREATE INDEX index_browser_pageview_events_on_created_at ON public.browser_pageview_events USING brin (created_at);------ Name: index_browser_pageview_events_on_topic_id; Type: INDEX; Schema: public; Owner: ------CREATE INDEX index_browser_pageview_events_on_topic_id ON public.browser_pageview_events USING btree (topic_id);-------- Name: index_browser_pageview_events_on_user_id; Type: INDEX; Schema: public; Owner: ------CREATE INDEX index_browser_pageview_events_on_user_id ON public.browser_pageview_events USING btree (user_id);------ Name: index_browser_pageview_session_engagements_on_created_at; Type: INDEX; Schema: public; Owner: ---@@ -25564,6 +25536,7 @@ ALTER TABLE ONLY public.ad_plugin_house_ads_groupsSET search_path TO "$user", public;INSERT INTO "schema_migrations" (version) VALUES+('20260925054715'),('20260923141924'),('20260923080644'),('20260923080642'),