Skip to content

A platform for community discussion. Free, open, simple.

FIX: Preserve subsecond traffic session durations (#43111)

Alan Guo Xiang Tan784376bcbfd6
diff --git a/app/services/admin_dashboard_site_traffic_explorer.rb b/app/services/admin_dashboard_site_traffic_explorer.rb
index 32551604076..7184c91fb64 100644
--- a/app/services/admin_dashboard_site_traffic_explorer.rb
+++ b/app/services/admin_dashboard_site_traffic_explorer.rb
@@ -390,10 +390,8 @@ class AdminDashboardSiteTrafficExplorer
END,
'average_session_duration_seconds', CASE
WHEN session_summary.distinct_sessions = 0 THEN 0
- ELSE ROUND(
- session_summary.engaged_seconds::numeric /
- session_summary.distinct_sessions
- )::integer
+ ELSE session_summary.engaged_seconds::numeric /
+ session_summary.distinct_sessions
END
) AS summary,
COALESCE(
diff --git a/frontend/discourse/admin/components/site-traffic-explorer.gjs b/frontend/discourse/admin/components/site-traffic-explorer.gjs
index 76c3a625090..f1be6b352b5 100644
--- a/frontend/discourse/admin/components/site-traffic-explorer.gjs
+++ b/frontend/discourse/admin/components/site-traffic-explorer.gjs
@@ -65,7 +65,8 @@ export default class SiteTrafficExplorer extends Component {
"admin.dashboard.site_traffic.kpi.average_session_duration.tooltip"
),
value: formatMinutesSeconds(
- this.summary.average_session_duration_seconds ?? 0
+ this.summary.average_session_duration_seconds ?? 0,
+ { subsecondPrecision: 2 }
),
},
];
diff --git a/frontend/discourse/app/lib/formatter.js b/frontend/discourse/app/lib/formatter.js
index 5393e154344..c50bd62c5f8 100644
--- a/frontend/discourse/app/lib/formatter.js
+++ b/frontend/discourse/app/lib/formatter.js
@@ -210,7 +210,24 @@ export function durationTiny(distance, ageOpts) {
return duration(distance, { format: "tiny", ...ageOpts });
}
-export function formatMinutesSeconds(seconds) {
+export function formatMinutesSeconds(seconds, { subsecondPrecision = 0 } = {}) {
+ if (seconds > 0 && seconds < 1 && subsecondPrecision > 0) {
+ const minimumSeconds = 10 ** -subsecondPrecision;
+ const lessThanMinimum = seconds < minimumSeconds;
+ const displayedSeconds = lessThanMinimum ? minimumSeconds : seconds;
+ const formattedSeconds = I18n.toNumber(displayedSeconds, {
+ precision: subsecondPrecision,
+ strip_insignificant_zeros: true,
+ });
+ const translationKey = lessThanMinimum
+ ? "dates.tiny.less_than_x_seconds.other"
+ : "dates.tiny.x_seconds.other";
+
+ return i18n(translationKey, {
+ count: formattedSeconds,
+ });
+ }
+
const totalSeconds = Math.floor(seconds);
if (totalSeconds < 60) {
diff --git a/frontend/discourse/tests/unit/lib/format-minutes-seconds-test.js b/frontend/discourse/tests/unit/lib/format-minutes-seconds-test.js
index bfe2d2bb1ca..0bc18465c38 100644
--- a/frontend/discourse/tests/unit/lib/format-minutes-seconds-test.js
+++ b/frontend/discourse/tests/unit/lib/format-minutes-seconds-test.js
@@ -10,9 +10,32 @@ module("Unit | Lib | formatMinutesSeconds", function (hooks) {
assert.strictEqual(formatMinutesSeconds(59), "59s");
});
+ test("formats seconds with optional subsecond precision", function (assert) {
+ assert.strictEqual(
+ formatMinutesSeconds(0, { subsecondPrecision: 2 }),
+ "0s"
+ );
+ assert.strictEqual(
+ formatMinutesSeconds(0.001, { subsecondPrecision: 2 }),
+ "< 0.01s"
+ );
+ assert.strictEqual(
+ formatMinutesSeconds(0.126, { subsecondPrecision: 2 }),
+ "0.13s"
+ );
+ assert.strictEqual(
+ formatMinutesSeconds(1.99, { subsecondPrecision: 2 }),
+ "1s"
+ );
+ });
+
test("formats a minute or more as Xm Ys with both units", function (assert) {
assert.strictEqual(formatMinutesSeconds(60), "1m 0s");
assert.strictEqual(formatMinutesSeconds(107), "1m 47s");
assert.strictEqual(formatMinutesSeconds(1800), "30m 0s");
+ assert.strictEqual(
+ formatMinutesSeconds(60.99, { subsecondPrecision: 2 }),
+ "1m 0s"
+ );
});
});
diff --git a/spec/services/admin_dashboard_site_traffic_explorer_spec.rb b/spec/services/admin_dashboard_site_traffic_explorer_spec.rb
index 98aed577422..04849684153 100644
--- a/spec/services/admin_dashboard_site_traffic_explorer_spec.rb
+++ b/spec/services/admin_dashboard_site_traffic_explorer_spec.rb
@@ -91,6 +91,14 @@ RSpec.describe AdminDashboardSiteTrafficExplorer do
context "when the query succeeds" do
it { is_expected.to run_successfully }
+ it "returns a fractional average session duration" do
+ Fabricate(:browser_pageview_session_engagement, session_id: "browser-0", engaged_seconds: 1)
+
+ average_session_duration = result.traffic.dig(:summary, "average_session_duration_seconds")
+
+ expect(average_session_duration).to eq(1.0 / browsers.size)
+ end
+
it "orders browser dimensions by pageviews" do
browser_dimensions = result.traffic.dig(:dimensions, "browsers")
diff --git a/spec/system/admin_dashboard_redesign/site_traffic_explorer_spec.rb b/spec/system/admin_dashboard_redesign/site_traffic_explorer_spec.rb
index 15719e23bdc..99899404ea7 100644
--- a/spec/system/admin_dashboard_redesign/site_traffic_explorer_spec.rb
+++ b/spec/system/admin_dashboard_redesign/site_traffic_explorer_spec.rb
@@ -78,7 +78,7 @@ RSpec.describe "Admin Dashboard Redesign | Site Traffic Explorer" do
Fabricate(
:browser_pageview_session_engagement,
session_id: "engaged-session",
- engaged_seconds: 20,
+ engaged_seconds: 1,
)
Fabricate(
:browser_pageview_event,
@@ -95,8 +95,8 @@ RSpec.describe "Admin Dashboard Redesign | Site Traffic Explorer" do
traffic.visit(start_date: "2026-05-14", end_date: "2026-05-14")
expect(traffic).to have_metric(label: "Distinct sessions", value: "2")
- expect(traffic).to have_metric(label: "Bounce rate", value: "50%")
- expect(traffic).to have_metric(label: "Average session duration", value: "10s")
+ expect(traffic).to have_metric(label: "Bounce rate", value: "100%")
+ expect(traffic).to have_metric(label: "Average session duration", value: "0.5s")
end
it "lets an admin preview traffic type filters before applying them",