Skip to content

A platform for community discussion. Free, open, simple.

A11Y: shorten long redundant input labels (#42419)

Kris7952f36dcbad
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 26141d02517..e3fecdb3a0d 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -3288,6 +3288,7 @@ en:
d_icon_grid_picker:
select_icon: "Select icon"
+ search_label: "Search icons"
search_placeholder: "Search icons..."
no_results: "No icons found"
results_count:
@@ -5768,6 +5769,7 @@ en:
invalid_video_url: This video cannot be played because the URL is invalid or unavailable.
keyboard_shortcuts_help:
+ search_label: "Search shortcuts"
search_placeholder: "Search for a shortcut by description or key combination"
shortcut_key_delimiter_comma: ", "
shortcut_key_delimiter_plus: "+"
diff --git a/frontend/discourse/app/components/modal/keyboard-shortcuts-help.gjs b/frontend/discourse/app/components/modal/keyboard-shortcuts-help.gjs
index e5c272de610..9507cabc48b 100644
--- a/frontend/discourse/app/components/modal/keyboard-shortcuts-help.gjs
+++ b/frontend/discourse/app/components/modal/keyboard-shortcuts-help.gjs
@@ -518,7 +518,7 @@ export default class KeyboardShortcutsHelp extends Component {
@filterAction={{this.filterShortcuts}}
@value={{this.searchTerm}}
placeholder={{i18n "keyboard_shortcuts_help.search_placeholder"}}
- aria-label={{i18n "keyboard_shortcuts_help.search_placeholder"}}
+ aria-label={{i18n "keyboard_shortcuts_help.search_label"}}
/>
<div class="keyboard-shortcuts-help__container">
diff --git a/frontend/discourse/app/ui-kit/d-icon-grid-picker/content.gjs b/frontend/discourse/app/ui-kit/d-icon-grid-picker/content.gjs
index cb6f8c11626..52952d73d9f 100644
--- a/frontend/discourse/app/ui-kit/d-icon-grid-picker/content.gjs
+++ b/frontend/discourse/app/ui-kit/d-icon-grid-picker/content.gjs
@@ -291,7 +291,7 @@ export default class DIconGridPickerContent extends Component {
>
<div class="d-icon-grid-picker__filter-container">
<DFilterInput
- aria-label={{i18n "d_icon_grid_picker.search_placeholder"}}
+ aria-label={{i18n "d_icon_grid_picker.search_label"}}
aria-controls="d-icon-grid-picker-listbox"
placeholder={{i18n "d_icon_grid_picker.search_placeholder"}}
@value={{this.filter}}