A platform for community discussion. Free, open, simple.
FIX: count self-replied topics as in progress in Topic outcomes (#42333)
Osama Sayegh7c27994e6936
diff --git a/plugins/discourse-solved/lib/discourse_solved/admin_dashboard_support.rb b/plugins/discourse-solved/lib/discourse_solved/admin_dashboard_support.rbindex cad29e6f1e2..1f0b011a8c4 100644--- a/plugins/discourse-solved/lib/discourse_solved/admin_dashboard_support.rb+++ b/plugins/discourse-solved/lib/discourse_solved/admin_dashboard_support.rb@@ -226,7 +226,6 @@ module DiscourseSolvedAND p.post_number > 1AND p.post_type = :post_typeAND p.deleted_at IS NULL- AND p.user_id <> t.user_id) AS has_replyFROM topics tLEFT JOIN discourse_solved_solved_topics st ON st.topic_id = t.iddiff --git a/plugins/discourse-solved/spec/lib/discourse_solved/admin_dashboard_support_spec.rb b/plugins/discourse-solved/spec/lib/discourse_solved/admin_dashboard_support_spec.rbindex 97bbf49d301..f2c85123373 100644--- a/plugins/discourse-solved/spec/lib/discourse_solved/admin_dashboard_support_spec.rb+++ b/plugins/discourse-solved/spec/lib/discourse_solved/admin_dashboard_support_spec.rb@@ -80,12 +80,12 @@ RSpec.describe DiscourseSolved::AdminDashboardSupport doexpect(dashboard[:topic_outcomes]).to eq(resolved: 1, in_progress: 1, unanswered: 1)end- it "treats a topic where only the author replied as unanswered, not in progress" do+ it "treats a topic where only the author replied as in progress, not unanswered" dotopic = Fabricate(:topic, category: support_category, user: author)Fabricate(:post, topic: topic, user: author)Fabricate(:post, topic: topic, user: author)- expect(dashboard[:topic_outcomes]).to eq(resolved: 0, in_progress: 0, unanswered: 1)+ expect(dashboard[:topic_outcomes]).to eq(resolved: 0, in_progress: 1, unanswered: 0)endit "serves cached data for the same scope and window within the TTL" do