Skip to content

A platform for community discussion. Free, open, simple.

UX: Convert AI translation's max days ago setting to a specific date setting instead (#42082)

Natalie Tay7c89948f1aed
diff --git a/config/locales/server.en.yml b/config/locales/server.en.yml
index 1b4c47b52fe..372629ac3f9 100644
--- a/config/locales/server.en.yml
+++ b/config/locales/server.en.yml
@@ -2979,6 +2979,7 @@ en:
errors:
invalid_css_color: "Invalid color. Enter a color name or hex value."
+ invalid_date: "Invalid date format. Please enter a valid date."
invalid_datetime: "Invalid datetime format. Please ensure you've entered a valid date and time."
invalid_email: "Invalid email address."
invalid_username: "There's no user with that username."
diff --git a/db/structure.sql b/db/structure.sql
index 42850b77fdb..0b7f7d2c48c 100644
--- a/db/structure.sql
+++ b/db/structure.sql
@@ -23052,6 +23052,8 @@ SET search_path TO "$user", public;
INSERT INTO "schema_migrations" (version) VALUES
('20260728071552'),
+('20260728045008'),
+('20260727085824'),
('20260727035337'),
('20260723100008'),
('20260723013754'),
diff --git a/frontend/discourse/admin/components/site-setting.gjs b/frontend/discourse/admin/components/site-setting.gjs
index 0e72e7dded6..e2481438c6b 100644
--- a/frontend/discourse/admin/components/site-setting.gjs
+++ b/frontend/discourse/admin/components/site-setting.gjs
@@ -32,6 +32,7 @@ import { i18n } from "discourse-i18n";
const CUSTOM_TYPES = [
"bool",
+ "date",
"datetime",
"integer",
"enum",
diff --git a/frontend/discourse/admin/components/site-settings/date.gjs b/frontend/discourse/admin/components/site-settings/date.gjs
new file mode 100644
index 00000000000..f361b59b825
--- /dev/null
+++ b/frontend/discourse/admin/components/site-settings/date.gjs
@@ -0,0 +1,39 @@
+import Component from "@glimmer/component";
+import { Input } from "@ember/component";
+import { on } from "@ember/modifier";
+import { action } from "@ember/object";
+import DButton from "discourse/ui-kit/d-button";
+
+export default class DateSetting extends Component {
+ @action
+ changeValue(event) {
+ this.args.changeValueCallback(event.target.value);
+ }
+
+ @action
+ reset() {
+ this.args.changeValueCallback("");
+ }
+
+ <template>
+ <div class="date-time-setting">
+ <Input
+ @type="date"
+ @value={{@value}}
+ @disabled={{@disabled}}
+ class="input-setting-date"
+ {{on "input" this.changeValue}}
+ />
+
+ {{#if @value}}
+ <DButton
+ @icon="trash-can"
+ @action={{this.reset}}
+ @disabled={{@disabled}}
+ @ariaLabel="admin.settings.reset"
+ class="btn-small"
+ />
+ {{/if}}
+ </div>
+ </template>
+}
diff --git a/frontend/discourse/tests/integration/components/site-settings/date-test.gjs b/frontend/discourse/tests/integration/components/site-settings/date-test.gjs
new file mode 100644
index 00000000000..ac397358f16
--- /dev/null
+++ b/frontend/discourse/tests/integration/components/site-settings/date-test.gjs
@@ -0,0 +1,42 @@
+import { click, fillIn, render } from "@ember/test-helpers";
+import { module, test } from "qunit";
+import DateSetting from "discourse/admin/components/site-settings/date";
+import { setupRenderingTest } from "discourse/tests/helpers/component-test";
+
+module("Integration | Component | SiteSettings | Date", function (hooks) {
+ setupRenderingTest(hooks);
+
+ test("shows and stores an ISO 8601 date", async function (assert) {
+ this.value = "2026-07-01";
+ this.changeValue = (value) => (this.value = value);
+
+ await render(
+ <template>
+ <DateSetting
+ @value={{this.value}}
+ @changeValueCallback={{this.changeValue}}
+ />
+ </template>
+ );
+
+ assert
+ .dom(".input-setting-date")
+ .hasValue("2026-07-01", "the input shows the stored date");
+
+ await fillIn(".input-setting-date", "2026-07-02");
+
+ assert.strictEqual(
+ this.value,
+ "2026-07-02",
+ "the input stores the selected date"
+ );
+
+ assert
+ .dom(".btn-small")
+ .hasAttribute("aria-label", "reset", "the clear button has a label");
+
+ await click(".btn-small");
+
+ assert.strictEqual(this.value, "", "the clear button stores a blank value");
+ });
+});
diff --git a/lib/site_settings/type_supervisor.rb b/lib/site_settings/type_supervisor.rb
index 5b36a1a30ad..20c15d6c202 100644
--- a/lib/site_settings/type_supervisor.rb
+++ b/lib/site_settings/type_supervisor.rb
@@ -75,6 +75,7 @@ class SiteSettings::TypeSupervisor
topic: 30,
datetime: 31,
icon: 32,
+ date: 33,
)
end
@@ -198,7 +199,8 @@ class SiteSettings::TypeSupervisor
nil
when self.class.types[:enum]
@defaults_provider[name].is_a?(Integer) ? value.to_i : value.to_s
- when self.class.types[:string], self.class.types[:datetime], self.class.types[:icon]
+ when self.class.types[:string], self.class.types[:datetime], self.class.types[:icon],
+ self.class.types[:date]
value.to_s
else
return value if self.class.types[type]
@@ -412,6 +414,8 @@ class SiteSettings::TypeSupervisor
TopicSettingValidator
when self.class.types[:datetime]
DatetimeSettingValidator
+ when self.class.types[:date]
+ DateSettingValidator
else
nil
end
diff --git a/lib/validators/date_setting_validator.rb b/lib/validators/date_setting_validator.rb
new file mode 100644
index 00000000000..ff48d0ae276
--- /dev/null
+++ b/lib/validators/date_setting_validator.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class DateSettingValidator
+ def initialize(opts = {})
+ @opts = opts
+ end
+
+ def valid_value?(val)
+ return true if val.blank?
+
+ Date.iso8601(val).iso8601 == val
+ rescue ArgumentError, TypeError
+ false
+ end
+
+ def error_message
+ I18n.t("site_settings.errors.invalid_date")
+ end
+end
diff --git a/plugins/discourse-ai/admin/assets/javascripts/discourse/components/ai-translations.gjs b/plugins/discourse-ai/admin/assets/javascripts/discourse/components/ai-translations.gjs
index 66e2d8c5d7a..100c0972233 100644
--- a/plugins/discourse-ai/admin/assets/javascripts/discourse/components/ai-translations.gjs
+++ b/plugins/discourse-ai/admin/assets/javascripts/discourse/components/ai-translations.gjs
@@ -328,7 +328,7 @@ export default class AiTranslations extends Component {
backfillStatusMessage(targets) {
if (
this.args.model?.backfill_enabled &&
- this.args.model?.backfill_max_age_days &&
+ this.args.model?.backfill_start_date &&
this.hourlyRate > 0
) {
const posts = targets?.find(({ target_type }) => target_type === "post");
@@ -337,15 +337,13 @@ export default class AiTranslations extends Component {
: 0;
if (totalRemaining && totalRemaining > 0) {
- const cutoffDate = new Date();
- cutoffDate.setDate(
- cutoffDate.getDate() - this.args.model.backfill_max_age_days
- );
-
- const formattedDate = cutoffDate.toLocaleDateString(undefined, {
+ const formattedDate = new Date(
+ this.args.model.backfill_start_date
+ ).toLocaleDateString(undefined, {
year: "numeric",
month: "long",
day: "numeric",
+ timeZone: "UTC",
});
return trustHTML(
diff --git a/plugins/discourse-ai/app/controllers/discourse_ai/admin/ai_translations_controller.rb b/plugins/discourse-ai/app/controllers/discourse_ai/admin/ai_translations_controller.rb
index b0a64cc9618..c41d9a87a22 100644
--- a/plugins/discourse-ai/app/controllers/discourse_ai/admin/ai_translations_controller.rb
+++ b/plugins/discourse-ai/app/controllers/discourse_ai/admin/ai_translations_controller.rb
@@ -40,10 +40,10 @@ module DiscourseAi
{
translation_id: DiscourseAi::Configuration::Module::TRANSLATION_ID,
enabled: DiscourseAi::Translation.enabled?,
- backfill_enabled: DiscourseAi::Translation.backfill_enabled?,
+ backfill_enabled: DiscourseAi::Translation.backfill_enabled?(target: Post),
translation_enabled: SiteSetting.ai_translation_enabled,
hourly_rate: SiteSetting.ai_translation_backfill_hourly_rate,
- backfill_max_age_days: SiteSetting.ai_translation_backfill_max_age_days,
+ backfill_start_date: SiteSetting.ai_translation_backfill_start_date.presence,
category_scope: SiteSetting.ai_translation_category_scope,
category_ids: DiscourseAi::Translation.category_ids,
}
diff --git a/plugins/discourse-ai/app/jobs/regular/localize_posts.rb b/plugins/discourse-ai/app/jobs/regular/localize_posts.rb
index c359e50ff97..842330943a3 100644
--- a/plugins/discourse-ai/app/jobs/regular/localize_posts.rb
+++ b/plugins/discourse-ai/app/jobs/regular/localize_posts.rb
@@ -10,7 +10,7 @@ module Jobs
pairs = args[:pairs]
raise Discourse::InvalidParameters.new(:pairs) if pairs.blank?
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Post)
unless DiscourseAi::Translation.credits_available_for_post_localization?
Rails.logger.info(
diff --git a/plugins/discourse-ai/app/jobs/regular/localize_topics.rb b/plugins/discourse-ai/app/jobs/regular/localize_topics.rb
index cd522602cb4..81e49162386 100644
--- a/plugins/discourse-ai/app/jobs/regular/localize_topics.rb
+++ b/plugins/discourse-ai/app/jobs/regular/localize_topics.rb
@@ -9,7 +9,7 @@ module Jobs
pairs = args[:pairs]
raise Discourse::InvalidParameters.new(:pairs) if pairs.blank?
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Topic)
unless DiscourseAi::Translation.credits_available_for_topic_localization?
Rails.logger.info(
diff --git a/plugins/discourse-ai/app/jobs/scheduled/categories_locale_detection_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/categories_locale_detection_backfill.rb
index 9e776a32706..c1e3251ea8b 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/categories_locale_detection_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/categories_locale_detection_backfill.rb
@@ -7,7 +7,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Category)
llm_model = find_llm_model
return if llm_model.blank?
diff --git a/plugins/discourse-ai/app/jobs/scheduled/category_localization_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/category_localization_backfill.rb
index 4962f6fafe4..2f171dd8a50 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/category_localization_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/category_localization_backfill.rb
@@ -6,7 +6,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Category)
short_text_llm =
find_llm_model_for_agent(SiteSetting.ai_translation_short_text_translator_agent)
diff --git a/plugins/discourse-ai/app/jobs/scheduled/post_localization_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/post_localization_backfill.rb
index d9cd1836263..5613055c716 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/post_localization_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/post_localization_backfill.rb
@@ -8,7 +8,7 @@ module Jobs
REDIS_KEY = "discourse-ai:localize_posts:in_progress"
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Post)
# Skip if previous batch is still running
return if Discourse.redis.get(REDIS_KEY).to_i > 0
diff --git a/plugins/discourse-ai/app/jobs/scheduled/posts_locale_detection_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/posts_locale_detection_backfill.rb
index a4087bc88d2..6f3dc0eb63e 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/posts_locale_detection_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/posts_locale_detection_backfill.rb
@@ -7,7 +7,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Post)
llm_model = find_llm_model
return if llm_model.blank?
diff --git a/plugins/discourse-ai/app/jobs/scheduled/sidebar_localization_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/sidebar_localization_backfill.rb
index 02f235396cd..e1f881b06b7 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/sidebar_localization_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/sidebar_localization_backfill.rb
@@ -6,7 +6,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: SidebarSection)
short_text_llm =
find_llm_model_for_agent(SiteSetting.ai_translation_short_text_translator_agent)
diff --git a/plugins/discourse-ai/app/jobs/scheduled/sidebar_sections_locale_detection_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/sidebar_sections_locale_detection_backfill.rb
index c3f5371fcec..e9f5a119964 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/sidebar_sections_locale_detection_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/sidebar_sections_locale_detection_backfill.rb
@@ -8,7 +8,7 @@ module Jobs
def execute(args)
return if !SiteSetting.content_localization_enabled
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: SidebarSection)
llm_model = find_llm_model
return if llm_model.blank?
diff --git a/plugins/discourse-ai/app/jobs/scheduled/tag_localization_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/tag_localization_backfill.rb
index f47ef6c4ddd..b984cc2cd34 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/tag_localization_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/tag_localization_backfill.rb
@@ -6,7 +6,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Tag)
short_text_llm =
find_llm_model_for_agent(SiteSetting.ai_translation_short_text_translator_agent)
diff --git a/plugins/discourse-ai/app/jobs/scheduled/tags_locale_detection_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/tags_locale_detection_backfill.rb
index cbeafc56d60..22d917b50d5 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/tags_locale_detection_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/tags_locale_detection_backfill.rb
@@ -7,7 +7,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Tag)
llm_model = find_llm_model
return if llm_model.blank?
diff --git a/plugins/discourse-ai/app/jobs/scheduled/topic_localization_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/topic_localization_backfill.rb
index 88501306457..c73a498f1b7 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/topic_localization_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/topic_localization_backfill.rb
@@ -6,7 +6,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Topic)
topic_title_llm =
find_llm_model_for_agent(SiteSetting.ai_translation_topic_title_translator_agent)
diff --git a/plugins/discourse-ai/app/jobs/scheduled/topics_locale_detection_backfill.rb b/plugins/discourse-ai/app/jobs/scheduled/topics_locale_detection_backfill.rb
index b74c8f3647b..2b9e79fcb1f 100644
--- a/plugins/discourse-ai/app/jobs/scheduled/topics_locale_detection_backfill.rb
+++ b/plugins/discourse-ai/app/jobs/scheduled/topics_locale_detection_backfill.rb
@@ -7,7 +7,7 @@ module Jobs
cluster_concurrency 1
def execute(args)
- return if !DiscourseAi::Translation.backfill_enabled?
+ return if !DiscourseAi::Translation.backfill_enabled?(target: Topic)
llm_model = find_llm_model
return if llm_model.blank?
diff --git a/plugins/discourse-ai/assets/javascripts/discourse/lib/ai-feature-setting-groups.js b/plugins/discourse-ai/assets/javascripts/discourse/lib/ai-feature-setting-groups.js
index e45b8b0ea2e..73818387ca3 100644
--- a/plugins/discourse-ai/assets/javascripts/discourse/lib/ai-feature-setting-groups.js
+++ b/plugins/discourse-ai/assets/javascripts/discourse/lib/ai-feature-setting-groups.js
@@ -197,7 +197,7 @@ export const AI_FEATURE_SETTING_GROUPS = {
"ai_translation_personal_messages",
"ai_translation_include_bot_content",
"ai_translation_max_post_length",
- "ai_translation_backfill_max_age_days",
+ "ai_translation_backfill_start_date",
"ai_translation_verbose_logs",
],
diff --git a/plugins/discourse-ai/config/locales/server.en.yml b/plugins/discourse-ai/config/locales/server.en.yml
index f40e8fdea12..31ff91fa63a 100644
--- a/plugins/discourse-ai/config/locales/server.en.yml
+++ b/plugins/discourse-ai/config/locales/server.en.yml
@@ -172,7 +172,7 @@ en:
ai_translation_personal_messages: "Controls which personal messages are translated. 'none' disables PM translation. 'group' translates only group PMs. 'all' translates all PMs."
ai_translation_include_bot_content: "When enabled, content written by bots (user IDs below 0) will also be sent for translation."
ai_translation_max_post_length: "The maximum number of characters for a post to be translated. Posts longer than this will not be translated."
- ai_translation_backfill_max_age_days: "The maximum age of a post and topic to be translated. Posts and topics older than this will not be translated. 0 disables backfilling, but will not disable translation of new posts."
+ ai_translation_backfill_start_date: "The UTC date from which historical posts and topics will be sent for translation backfilling. Leave blank to disable backfilling. New content will continue to be translated."
ai_translation_backfill_hourly_rate: "The number of posts and topics to translate per hour during backfill operations. Set to 0 to disable automatic backfilling of translations for existing content."
ai_translation_backfill_parallel_jobs: "The number of parallel post localization jobs to run per backfill cycle. Higher values increase throughput but consume more resources."
ai_usage_rollup_after_days: "Number of days to keep per-request AI usage stats before rolling them into daily aggregates. Set to 0 to disable rollups."
diff --git a/plugins/discourse-ai/config/settings.yml b/plugins/discourse-ai/config/settings.yml
index 39de2c77ad9..845dd93764d 100644
--- a/plugins/discourse-ai/config/settings.yml
+++ b/plugins/discourse-ai/config/settings.yml
@@ -581,10 +581,9 @@ discourse_ai:
default: 10000
client: false
area: "ai-features/translation"
- ai_translation_backfill_max_age_days:
- default: 5
- min: 0
- max: 20000
+ ai_translation_backfill_start_date:
+ default: ""
+ type: "date"
client: false
area: "ai-features/translation"
diff --git a/plugins/discourse-ai/db/migrate/20260727085824_convert_ai_translation_backfill_max_age_to_start_date.rb b/plugins/discourse-ai/db/migrate/20260727085824_convert_ai_translation_backfill_max_age_to_start_date.rb
new file mode 100644
index 00000000000..8b6b09d4215
--- /dev/null
+++ b/plugins/discourse-ai/db/migrate/20260727085824_convert_ai_translation_backfill_max_age_to_start_date.rb
@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+class ConvertAiTranslationBackfillMaxAgeToStartDate < ActiveRecord::Migration[8.0]
+ def up
+ execute <<~SQL
+ WITH previous_settings AS (
+ SELECT
+ (
+ SELECT value
+ FROM site_settings
+ WHERE name = 'discourse_ai_enabled'
+ ) AS discourse_ai_enabled,
+ (
+ SELECT value
+ FROM site_settings
+ WHERE name = 'ai_translation_enabled'
+ ) AS ai_translation_enabled,
+ (
+ SELECT value::integer
+ FROM site_settings
+ WHERE name = 'ai_translation_backfill_hourly_rate'
+ ) AS hourly_rate,
+ COALESCE(
+ (
+ SELECT value::integer
+ FROM site_settings
+ WHERE name = 'ai_translation_backfill_max_age_days'
+ ),
+ 5
+ ) AS max_age_days
+ )
+ INSERT INTO site_settings(name, data_type, value, created_at, updated_at)
+ SELECT
+ 'ai_translation_backfill_start_date',
+ 33,
+ (
+ (CURRENT_TIMESTAMP AT TIME ZONE 'UTC') -
+ max_age_days * INTERVAL '1 day'
+ )::date::text,
+ CURRENT_TIMESTAMP,
+ CURRENT_TIMESTAMP
+ FROM previous_settings
+ WHERE discourse_ai_enabled = 't'
+ AND ai_translation_enabled = 't'
+ AND (hourly_rate IS NULL OR hourly_rate > 0)
+ AND max_age_days > 0
+ AND NOT EXISTS (
+ SELECT 1
+ FROM site_settings
+ WHERE name = 'ai_translation_backfill_start_date'
+ )
+ SQL
+ end
+
+ def down
+ raise ActiveRecord::IrreversibleMigration
+ end
+end
diff --git a/plugins/discourse-ai/db/post_migrate/20260728045008_remove_ai_translation_backfill_max_age_setting.rb b/plugins/discourse-ai/db/post_migrate/20260728045008_remove_ai_translation_backfill_max_age_setting.rb
new file mode 100644
index 00000000000..95f4951ca44
--- /dev/null
+++ b/plugins/discourse-ai/db/post_migrate/20260728045008_remove_ai_translation_backfill_max_age_setting.rb
@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+class RemoveAiTranslationBackfillMaxAgeSetting < ActiveRecord::Migration[8.0]
+ def up
+ execute "DELETE FROM site_settings WHERE name = 'ai_translation_backfill_max_age_days'"
+ end
+
+ def down
+ raise ActiveRecord::IrreversibleMigration
+ end
+end
diff --git a/plugins/discourse-ai/lib/translation.rb b/plugins/discourse-ai/lib/translation.rb
index ba3cc272fbd..596239cdb82 100644
--- a/plugins/discourse-ai/lib/translation.rb
+++ b/plugins/discourse-ai/lib/translation.rb
@@ -47,9 +47,17 @@ module DiscourseAi
end
end
- def self.backfill_enabled?
+ def self.backfill_enabled?(target: nil)
enabled? && SiteSetting.ai_translation_backfill_hourly_rate > 0 &&
- SiteSetting.ai_translation_backfill_max_age_days > 0
+ (![Post, Topic].include?(target) || backfill_start_at.present?)
+ end
+
+ def self.backfill_start_at
+ value = SiteSetting.ai_translation_backfill_start_date
+ return if value.blank?
+
+ date = Date.iso8601(value)
+ Time.utc(date.year, date.month, date.day)
end
def self.category_ids
diff --git a/plugins/discourse-ai/lib/translation/post_candidates.rb b/plugins/discourse-ai/lib/translation/post_candidates.rb
index 5dda935a9b5..113a459ba11 100644
--- a/plugins/discourse-ai/lib/translation/post_candidates.rb
+++ b/plugins/discourse-ai/lib/translation/post_candidates.rb
@@ -54,12 +54,9 @@ module DiscourseAi
end
def self.progress_details
+ backfill_start_at = DiscourseAi::Translation.backfill_start_at
main_posts =
- Post
- .where(
- "posts.created_at > ?",
- SiteSetting.ai_translation_backfill_max_age_days.days.ago,
- )
+ (backfill_start_at ? Post.where("posts.created_at >= ?", backfill_start_at) : Post.none)
.where(deleted_at: nil)
.where.not(raw: [nil, ""])
.where("LENGTH(posts.raw) <= ?", SiteSetting.ai_translation_max_post_length)
@@ -225,12 +222,9 @@ module DiscourseAi
# all posts that are eligible for translation based on site settings,
# including those without locale detected yet.
def self.get
+ backfill_start_at = DiscourseAi::Translation.backfill_start_at
posts =
- Post
- .where(
- "posts.created_at > ?",
- SiteSetting.ai_translation_backfill_max_age_days.days.ago,
- )
+ (backfill_start_at ? Post.where("posts.created_at >= ?", backfill_start_at) : Post.none)
.where(deleted_at: nil)
.where.not(raw: [nil, ""])
.where("LENGTH(posts.raw) <= ?", SiteSetting.ai_translation_max_post_length)
diff --git a/plugins/discourse-ai/lib/translation/progress.rb b/plugins/discourse-ai/lib/translation/progress.rb
index c9b90ad848b..d59e2106a2f 100644
--- a/plugins/discourse-ai/lib/translation/progress.rb
+++ b/plugins/discourse-ai/lib/translation/progress.rb
@@ -65,7 +65,7 @@ module DiscourseAi
def self.settings_cache_key_parts
[
SiteSetting.content_localization_supported_locales,
- SiteSetting.ai_translation_backfill_max_age_days,
+ SiteSetting.ai_translation_backfill_start_date,
SiteSetting.ai_translation_include_bot_content,
SiteSetting.ai_translation_max_post_length,
SiteSetting.ai_translation_personal_messages,
diff --git a/plugins/discourse-ai/lib/translation/topic_candidates.rb b/plugins/discourse-ai/lib/translation/topic_candidates.rb
index 45e3d140e1e..6592d088108 100644
--- a/plugins/discourse-ai/lib/translation/topic_candidates.rb
+++ b/plugins/discourse-ai/lib/translation/topic_candidates.rb
@@ -54,10 +54,14 @@ module DiscourseAi
end
def self.progress_details
+ backfill_start_at = DiscourseAi::Translation.backfill_start_at
main_topics =
- Topic.where(
- "topics.created_at > ?",
- SiteSetting.ai_translation_backfill_max_age_days.days.ago,
+ (
+ if backfill_start_at
+ Topic.where("topics.created_at >= ?", backfill_start_at)
+ else
+ Topic.none
+ end
).where(deleted_at: nil)
main_topics =
main_topics.where(
@@ -208,10 +212,14 @@ module DiscourseAi
# all topics that are eligible for translation based on site settings,
# including those without locale detected yet.
def self.get
+ backfill_start_at = DiscourseAi::Translation.backfill_start_at
topics =
- Topic.where(
- "topics.created_at > ?",
- SiteSetting.ai_translation_backfill_max_age_days.days.ago,
+ (
+ if backfill_start_at
+ Topic.where("topics.created_at >= ?", backfill_start_at)
+ else
+ Topic.none
+ end
).where(deleted_at: nil)
topics =
diff --git a/plugins/discourse-ai/spec/db/migrate/20260727085824_convert_ai_translation_backfill_max_age_to_start_date_spec.rb b/plugins/discourse-ai/spec/db/migrate/20260727085824_convert_ai_translation_backfill_max_age_to_start_date_spec.rb
new file mode 100644
index 00000000000..383a28cb41f
--- /dev/null
+++ b/plugins/discourse-ai/spec/db/migrate/20260727085824_convert_ai_translation_backfill_max_age_to_start_date_spec.rb
@@ -0,0 +1,139 @@
+# frozen_string_literal: true
+
+require Rails.root.join(
+ "plugins/discourse-ai/db/migrate/20260727085824_convert_ai_translation_backfill_max_age_to_start_date",
+ )
+
+describe ConvertAiTranslationBackfillMaxAgeToStartDate do
+ subject(:migration) { described_class.new }
+
+ let(:connection) { ActiveRecord::Base.connection }
+
+ around { |example| ActiveRecord::Migration.suppress_messages { example.run } }
+
+ before do
+ enable_current_plugin
+ delete_settings
+ end
+
+ after { delete_settings }
+
+ def delete_settings
+ connection.execute(<<~SQL)
+ DELETE FROM site_settings
+ WHERE name IN (
+ 'discourse_ai_enabled',
+ 'ai_translation_enabled',
+ 'ai_translation_backfill_hourly_rate',
+ 'ai_translation_backfill_max_age_days',
+ 'ai_translation_backfill_start_date'
+ )
+ SQL
+ end
+
+ def store_setting(name, value, data_type)
+ DB.exec(<<~SQL, name:, value:, data_type:)
+ INSERT INTO site_settings(name, data_type, value, created_at, updated_at)
+ VALUES (:name, :data_type, :value, NOW(), NOW())
+ SQL
+ end
+
+ def configure_backfill(
+ discourse_ai_enabled: true,
+ ai_translation_enabled: true,
+ hourly_rate: 50,
+ max_age_days: 30
+ )
+ unless discourse_ai_enabled.nil?
+ store_setting("discourse_ai_enabled", discourse_ai_enabled ? "t" : "f", 5)
+ end
+ unless ai_translation_enabled.nil?
+ store_setting("ai_translation_enabled", ai_translation_enabled ? "t" : "f", 5)
+ end
+ store_setting("ai_translation_backfill_hourly_rate", hourly_rate, 3) if hourly_rate
+ store_setting("ai_translation_backfill_max_age_days", max_age_days, 3) if max_age_days
+ end
+
+ def setting(name)
+ DB.query("SELECT data_type, value FROM site_settings WHERE name = :name", name:).first
+ end
+
+ def utc_date
+ DB.query_single("SELECT (CURRENT_TIMESTAMP AT TIME ZONE 'UTC')::date").first
+ end
+
+ describe "#up" do
+ it "converts a positive max age override to a fixed UTC date" do
+ configure_backfill
+
+ expected_start_date = (utc_date - 30).iso8601
+
+ migration.up
+
+ migrated_setting = setting("ai_translation_backfill_start_date")
+ expect(migrated_setting.data_type).to eq(33)
+ expect(migrated_setting.value).to eq(expected_start_date)
+ expect(setting("ai_translation_backfill_max_age_days").value).to eq("30")
+ end
+
+ it "uses blank when the max age disables backfilling" do
+ configure_backfill(max_age_days: 0)
+
+ migration.up
+
+ expect(setting("ai_translation_backfill_start_date")).to be_nil
+ expect(setting("ai_translation_backfill_max_age_days").value).to eq("0")
+ end
+
+ it "uses blank when the hourly rate disables backfilling" do
+ configure_backfill(hourly_rate: 0)
+
+ migration.up
+
+ expect(setting("ai_translation_backfill_start_date")).to be_nil
+ end
+
+ it "uses blank when Discourse AI is disabled" do
+ configure_backfill(discourse_ai_enabled: nil)
+
+ migration.up
+
+ expect(setting("ai_translation_backfill_start_date")).to be_nil
+ end
+
+ it "uses blank when AI translation is disabled" do
+ configure_backfill(ai_translation_enabled: nil)
+
+ migration.up
+
+ expect(setting("ai_translation_backfill_start_date")).to be_nil
+ end
+
+ it "converts the previous five-day default when backfilling is enabled" do
+ configure_backfill(hourly_rate: nil, max_age_days: nil)
+
+ expected_start_date = (utc_date - 5).iso8601
+
+ migration.up
+
+ migrated_setting = setting("ai_translation_backfill_start_date")
+ expect(migrated_setting.data_type).to eq(33)
+ expect(migrated_setting.value).to eq(expected_start_date)
+ end
+
+ it "keeps an existing start date" do
+ configure_backfill
+ store_setting("ai_translation_backfill_start_date", "2026-07-01", 33)
+
+ migration.up
+
+ expect(setting("ai_translation_backfill_start_date").value).to eq("2026-07-01")
+ end
+
+ it "does not create a start date when no previous settings exist" do
+ migration.up
+
+ expect(setting("ai_translation_backfill_start_date")).to be_nil
+ end
+ end
+end
diff --git a/plugins/discourse-ai/spec/jobs/regular/localize_posts_spec.rb b/plugins/discourse-ai/spec/jobs/regular/localize_posts_spec.rb
index eef132819db..7d67ac8f3d2 100644
--- a/plugins/discourse-ai/spec/jobs/regular/localize_posts_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/regular/localize_posts_spec.rb
@@ -11,7 +11,7 @@ describe Jobs::LocalizePosts do
SiteSetting.ai_translation_enabled = true
SiteSetting.content_localization_supported_locales = "en|ja|de"
SiteSetting.ai_translation_backfill_hourly_rate = 100
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
end
it "does nothing when translator is disabled" do
diff --git a/plugins/discourse-ai/spec/jobs/regular/localize_topics_spec.rb b/plugins/discourse-ai/spec/jobs/regular/localize_topics_spec.rb
index 9fd7b9883be..35c5f4d310d 100644
--- a/plugins/discourse-ai/spec/jobs/regular/localize_topics_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/regular/localize_topics_spec.rb
@@ -11,7 +11,7 @@ describe Jobs::LocalizeTopics do
SiteSetting.ai_translation_enabled = true
SiteSetting.content_localization_supported_locales = "en|ja|de"
SiteSetting.ai_translation_backfill_hourly_rate = 100
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
end
it "does nothing when translator is disabled" do
diff --git a/plugins/discourse-ai/spec/jobs/scheduled/post_localization_backfill_spec.rb b/plugins/discourse-ai/spec/jobs/scheduled/post_localization_backfill_spec.rb
index 62602375439..61e052a12b8 100644
--- a/plugins/discourse-ai/spec/jobs/scheduled/post_localization_backfill_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/scheduled/post_localization_backfill_spec.rb
@@ -7,7 +7,7 @@ describe Jobs::PostLocalizationBackfill do
enable_current_plugin
assign_fake_provider_to(:ai_default_llm_model)
SiteSetting.ai_translation_backfill_hourly_rate = 100
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
SiteSetting.content_localization_supported_locales = "en"
SiteSetting.ai_translation_enabled = true
SiteSetting.ai_translation_category_scope = "all"
diff --git a/plugins/discourse-ai/spec/jobs/scheduled/posts_locale_detection_backfill_spec.rb b/plugins/discourse-ai/spec/jobs/scheduled/posts_locale_detection_backfill_spec.rb
index 21b96d36f7b..aa122d54ba8 100644
--- a/plugins/discourse-ai/spec/jobs/scheduled/posts_locale_detection_backfill_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/scheduled/posts_locale_detection_backfill_spec.rb
@@ -11,6 +11,7 @@ describe Jobs::PostsLocaleDetectionBackfill do
enable_current_plugin
SiteSetting.ai_translation_enabled = true
SiteSetting.ai_translation_backfill_hourly_rate = 100
+ SiteSetting.ai_translation_backfill_start_date = 1.day.ago.utc.to_date.iso8601
SiteSetting.content_localization_supported_locales = "en"
SiteSetting.ai_translation_category_scope = "all"
SiteSetting.ai_translation_categories = ""
@@ -140,13 +141,13 @@ describe Jobs::PostsLocaleDetectionBackfill do
end
end
- describe "with max age limit" do
+ describe "with a backfill start date" do
fab!(:old_post) { Fabricate(:post, locale: nil, created_at: 10.days.ago) }
fab!(:new_post) { Fabricate(:post, locale: nil, created_at: 2.days.ago) }
- before { SiteSetting.ai_translation_backfill_max_age_days = 5 }
+ before { SiteSetting.ai_translation_backfill_start_date = 5.days.ago.utc.to_date.iso8601 }
- it "only processes posts within the age limit" do
+ it "only processes posts created after the start date" do
# other posts
DiscourseAi::Translation::PostLocaleDetector.expects(:detect_locale).at_least_once
@@ -156,8 +157,8 @@ describe Jobs::PostsLocaleDetectionBackfill do
job.execute({})
end
- it "processes all posts when setting is large" do
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ it "processes older posts when the start date is earlier" do
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
# other posts
DiscourseAi::Translation::PostLocaleDetector.expects(:detect_locale).at_least_once
diff --git a/plugins/discourse-ai/spec/jobs/scheduled/sidebar_localization_backfill_spec.rb b/plugins/discourse-ai/spec/jobs/scheduled/sidebar_localization_backfill_spec.rb
index 410791ad6ea..3d4fdca76e2 100644
--- a/plugins/discourse-ai/spec/jobs/scheduled/sidebar_localization_backfill_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/scheduled/sidebar_localization_backfill_spec.rb
@@ -6,7 +6,6 @@ describe Jobs::SidebarLocalizationBackfill do
assign_fake_provider_to(:ai_default_llm_model)
SiteSetting.ai_translation_enabled = true
SiteSetting.ai_translation_backfill_hourly_rate = 100
- SiteSetting.ai_translation_backfill_max_age_days = 30
SiteSetting.content_localization_supported_locales = "pt_BR|zh_CN"
end
diff --git a/plugins/discourse-ai/spec/jobs/scheduled/tag_localization_backfill_spec.rb b/plugins/discourse-ai/spec/jobs/scheduled/tag_localization_backfill_spec.rb
index ae48ec5ec27..00056aea852 100644
--- a/plugins/discourse-ai/spec/jobs/scheduled/tag_localization_backfill_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/scheduled/tag_localization_backfill_spec.rb
@@ -6,7 +6,6 @@ describe Jobs::TagLocalizationBackfill do
assign_fake_provider_to(:ai_default_llm_model)
SiteSetting.ai_translation_enabled = true
SiteSetting.ai_translation_backfill_hourly_rate = 100
- SiteSetting.ai_translation_backfill_max_age_days = 30
SiteSetting.content_localization_supported_locales = "pt_BR|zh_CN"
end
diff --git a/plugins/discourse-ai/spec/jobs/scheduled/tags_locale_detection_backfill_spec.rb b/plugins/discourse-ai/spec/jobs/scheduled/tags_locale_detection_backfill_spec.rb
index f5f19098804..5e9391fa376 100644
--- a/plugins/discourse-ai/spec/jobs/scheduled/tags_locale_detection_backfill_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/scheduled/tags_locale_detection_backfill_spec.rb
@@ -10,7 +10,6 @@ describe Jobs::TagsLocaleDetectionBackfill do
enable_current_plugin
SiteSetting.ai_translation_enabled = true
SiteSetting.ai_translation_backfill_hourly_rate = 100
- SiteSetting.ai_translation_backfill_max_age_days = 30
SiteSetting.content_localization_supported_locales = "en"
end
diff --git a/plugins/discourse-ai/spec/jobs/scheduled/topic_localization_backfill_spec.rb b/plugins/discourse-ai/spec/jobs/scheduled/topic_localization_backfill_spec.rb
index 3d10407f60a..dc93c82c2e1 100644
--- a/plugins/discourse-ai/spec/jobs/scheduled/topic_localization_backfill_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/scheduled/topic_localization_backfill_spec.rb
@@ -7,7 +7,7 @@ describe Jobs::TopicLocalizationBackfill do
enable_current_plugin
assign_fake_provider_to(:ai_default_llm_model)
SiteSetting.ai_translation_backfill_hourly_rate = 100
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
SiteSetting.content_localization_supported_locales = "en"
SiteSetting.ai_translation_enabled = true
SiteSetting.ai_translation_category_scope = "all"
diff --git a/plugins/discourse-ai/spec/jobs/scheduled/topics_locale_detection_backfill_spec.rb b/plugins/discourse-ai/spec/jobs/scheduled/topics_locale_detection_backfill_spec.rb
index 87904ecf2c8..4cc96f51992 100644
--- a/plugins/discourse-ai/spec/jobs/scheduled/topics_locale_detection_backfill_spec.rb
+++ b/plugins/discourse-ai/spec/jobs/scheduled/topics_locale_detection_backfill_spec.rb
@@ -11,6 +11,7 @@ describe Jobs::TopicsLocaleDetectionBackfill do
enable_current_plugin
SiteSetting.ai_translation_enabled = true
SiteSetting.ai_translation_backfill_hourly_rate = 100
+ SiteSetting.ai_translation_backfill_start_date = 1.day.ago.utc.to_date.iso8601
SiteSetting.content_localization_supported_locales = "en"
SiteSetting.ai_translation_category_scope = "all"
SiteSetting.ai_translation_categories = ""
@@ -139,7 +140,7 @@ describe Jobs::TopicsLocaleDetectionBackfill do
end
end
- describe "with max age limit" do
+ describe "with a backfill start date" do
fab!(:old_topic) do
Fabricate(:topic, locale: nil, created_at: 10.days.ago, category: topic.category)
end
@@ -150,18 +151,18 @@ describe Jobs::TopicsLocaleDetectionBackfill do
before do
DiscourseAi::Translation::TopicLocaleDetector.expects(:detect_locale).at_least_once
- SiteSetting.ai_translation_backfill_max_age_days = 5
+ SiteSetting.ai_translation_backfill_start_date = 5.days.ago.utc.to_date.iso8601
end
- it "only processes topics within the age limit" do
+ it "only processes topics created after the start date" do
DiscourseAi::Translation::TopicLocaleDetector.expects(:detect_locale).with(new_topic).once
DiscourseAi::Translation::TopicLocaleDetector.expects(:detect_locale).with(old_topic).never
job.execute({ limit: 10 })
end
- it "processes all topics when setting is large" do
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ it "processes older topics when the start date is earlier" do
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
DiscourseAi::Translation::TopicLocaleDetector.expects(:detect_locale).with(new_topic).once
DiscourseAi::Translation::TopicLocaleDetector.expects(:detect_locale).with(old_topic).once
diff --git a/plugins/discourse-ai/spec/lib/translation/post_candidates_spec.rb b/plugins/discourse-ai/spec/lib/translation/post_candidates_spec.rb
index a94143b6fe8..cc4d2ef0bb6 100644
--- a/plugins/discourse-ai/spec/lib/translation/post_candidates_spec.rb
+++ b/plugins/discourse-ai/spec/lib/translation/post_candidates_spec.rb
@@ -2,6 +2,7 @@
describe DiscourseAi::Translation::PostCandidates do
before do
+ SiteSetting.ai_translation_backfill_start_date = 1.day.ago.utc.to_date.iso8601
SiteSetting.ai_translation_category_scope = "all"
SiteSetting.ai_translation_categories = ""
end
@@ -25,14 +26,16 @@ describe DiscourseAi::Translation::PostCandidates do
end
end
- it "does not return posts older than ai_translation_backfill_max_age_days" do
- post =
- Fabricate(
- :post,
- created_at: SiteSetting.ai_translation_backfill_max_age_days.days.ago - 1.day,
- )
+ it "returns posts created on or after the backfill start date" do
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
+ start_date = DiscourseAi::Translation.backfill_start_at
+ older_post = Fabricate(:post, created_at: start_date - 1.second)
+ post_at_start_date = Fabricate(:post, created_at: start_date)
+ newer_post = Fabricate(:post, created_at: start_date + 1.second)
- expect(DiscourseAi::Translation::PostCandidates.get).not_to include(post)
+ posts = described_class.get
+ expect(posts).not_to include(older_post)
+ expect(posts).to include(post_at_start_date, newer_post)
end
it "does not return deleted posts" do
@@ -135,7 +138,7 @@ describe DiscourseAi::Translation::PostCandidates do
fab!(:target_category, :category)
before do
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
SiteSetting.content_localization_supported_locales = "en|ja|de"
SiteSetting.ai_translation_category_scope = "all"
SiteSetting.ai_translation_categories = ""
@@ -221,7 +224,7 @@ describe DiscourseAi::Translation::PostCandidates do
before do
SiteSetting.content_localization_supported_locales = "en_GB|fr"
- SiteSetting.ai_translation_backfill_max_age_days = 30
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
SiteSetting.ai_translation_category_scope = "include_strict"
SiteSetting.ai_translation_categories = target_category.id.to_s
SiteSetting.ai_translation_personal_messages = "none"
@@ -250,7 +253,7 @@ describe DiscourseAi::Translation::PostCandidates do
before do
SiteSetting.content_localization_supported_locales = "en_GB|fr"
- SiteSetting.ai_translation_backfill_max_age_days = 30
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
SiteSetting.ai_translation_category_scope = "include_strict"
SiteSetting.ai_translation_categories = target_category.id.to_s
SiteSetting.ai_translation_personal_messages = "none"
diff --git a/plugins/discourse-ai/spec/lib/translation/progress_spec.rb b/plugins/discourse-ai/spec/lib/translation/progress_spec.rb
index ff4043a7820..564be9b0e6b 100644
--- a/plugins/discourse-ai/spec/lib/translation/progress_spec.rb
+++ b/plugins/discourse-ai/spec/lib/translation/progress_spec.rb
@@ -4,7 +4,7 @@ describe DiscourseAi::Translation::Progress do
before do
Discourse.cache.clear
SiteSetting.content_localization_supported_locales = "en|fr"
- SiteSetting.ai_translation_backfill_max_age_days = 30
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
SiteSetting.ai_translation_category_scope = "public"
allow(DiscourseAi::Translation::PostCandidates).to receive(:progress_summary).and_return(
diff --git a/plugins/discourse-ai/spec/lib/translation/topic_candidates_spec.rb b/plugins/discourse-ai/spec/lib/translation/topic_candidates_spec.rb
index c75e18b2fec..41c824c2f9b 100644
--- a/plugins/discourse-ai/spec/lib/translation/topic_candidates_spec.rb
+++ b/plugins/discourse-ai/spec/lib/translation/topic_candidates_spec.rb
@@ -2,6 +2,7 @@
describe DiscourseAi::Translation::TopicCandidates do
before do
+ SiteSetting.ai_translation_backfill_start_date = 1.day.ago.utc.to_date.iso8601
SiteSetting.ai_translation_category_scope = "all"
SiteSetting.ai_translation_categories = ""
end
@@ -25,23 +26,23 @@ describe DiscourseAi::Translation::TopicCandidates do
end
end
- it "does not return topics older than ai_translation_backfill_max_age_days" do
- topic =
- Fabricate(
- :topic,
- created_at: SiteSetting.ai_translation_backfill_max_age_days.days.ago - 1.day,
- )
+ it "returns topics created on or after the backfill start date" do
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
+ start_date = DiscourseAi::Translation.backfill_start_at
+ older_topic = Fabricate(:topic, created_at: start_date - 1.second)
+ topic_at_start_date = Fabricate(:topic, created_at: start_date)
+ newer_topic = Fabricate(:topic, created_at: start_date + 1.second)
- expect(DiscourseAi::Translation::TopicCandidates.get).not_to include(topic)
+ topics = described_class.get
+ expect(topics).not_to include(older_topic)
+ expect(topics).to include(topic_at_start_date, newer_topic)
end
- it "returns banner topics even when older than max_age_days" do
+ it "returns banner topics even when older than the backfill start date" do
+ start_date = 30.days.ago
+ SiteSetting.ai_translation_backfill_start_date = start_date.utc.to_date.iso8601
banner_topic =
- Fabricate(
- :topic,
- archetype: Archetype.banner,
- created_at: SiteSetting.ai_translation_backfill_max_age_days.days.ago - 30.days,
- )
+ Fabricate(:topic, archetype: Archetype.banner, created_at: start_date - 30.days)
expect(DiscourseAi::Translation::TopicCandidates.get).to include(banner_topic)
end
@@ -156,7 +157,7 @@ describe DiscourseAi::Translation::TopicCandidates do
fab!(:target_category, :category)
before do
- SiteSetting.ai_translation_backfill_max_age_days = 100
+ SiteSetting.ai_translation_backfill_start_date = 100.days.ago.utc.to_date.iso8601
SiteSetting.content_localization_supported_locales = "en|ja|de"
SiteSetting.ai_translation_category_scope = "all"
SiteSetting.ai_translation_categories = ""
@@ -316,7 +317,7 @@ describe DiscourseAi::Translation::TopicCandidates do
end
it "returns nil - nil for done and total when no topics are present" do
- SiteSetting.ai_translation_backfill_max_age_days = 0
+ SiteSetting.ai_translation_backfill_start_date = ""
completion = DiscourseAi::Translation::TopicCandidates.calculate_completion_per_locale("es")
expect(completion).to eq({ done: 0, total: 0 })
@@ -328,7 +329,7 @@ describe DiscourseAi::Translation::TopicCandidates do
before do
SiteSetting.content_localization_supported_locales = "en_GB|fr"
- SiteSetting.ai_translation_backfill_max_age_days = 30
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
SiteSetting.ai_translation_category_scope = "include_strict"
SiteSetting.ai_translation_categories = target_category.id.to_s
SiteSetting.ai_translation_personal_messages = "none"
@@ -356,7 +357,7 @@ describe DiscourseAi::Translation::TopicCandidates do
before do
SiteSetting.content_localization_supported_locales = "en_GB|fr"
- SiteSetting.ai_translation_backfill_max_age_days = 30
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
SiteSetting.ai_translation_category_scope = "include_strict"
SiteSetting.ai_translation_categories = target_category.id.to_s
SiteSetting.ai_translation_personal_messages = "none"
diff --git a/plugins/discourse-ai/spec/lib/translation/translation_spec.rb b/plugins/discourse-ai/spec/lib/translation/translation_spec.rb
index 7d5b9b72b72..7fa76b04b8a 100644
--- a/plugins/discourse-ai/spec/lib/translation/translation_spec.rb
+++ b/plugins/discourse-ai/spec/lib/translation/translation_spec.rb
@@ -18,6 +18,32 @@ describe DiscourseAi::Translation do
end
end
+ describe ".backfill_start_at" do
+ it "returns midnight UTC on the configured date" do
+ SiteSetting.ai_translation_backfill_start_date = "2026-07-01"
+
+ expect(described_class.backfill_start_at.iso8601).to eq("2026-07-01T00:00:00Z")
+ end
+ end
+
+ describe ".backfill_enabled?" do
+ it "uses the start date only for post and topic backfills" do
+ SiteSetting.content_localization_supported_locales = "es"
+ SiteSetting.ai_translation_backfill_hourly_rate = 50
+ SiteSetting.ai_translation_backfill_start_date = ""
+
+ expect(described_class.backfill_enabled?).to eq(true)
+ expect(described_class.backfill_enabled?(target: Category)).to eq(true)
+ expect(described_class.backfill_enabled?(target: Post)).to eq(false)
+ expect(described_class.backfill_enabled?(target: Topic)).to eq(false)
+
+ SiteSetting.ai_translation_backfill_start_date = "2026-07-01"
+
+ expect(described_class.backfill_enabled?(target: Post)).to eq(true)
+ expect(described_class.backfill_enabled?(target: Topic)).to eq(true)
+ end
+ end
+
describe ".supported_locale_bases_cte" do
it "normalizes and deduplicates supported locale bases" do
sql = <<~SQL
diff --git a/plugins/discourse-ai/spec/requests/admin/ai_translations_controller_spec.rb b/plugins/discourse-ai/spec/requests/admin/ai_translations_controller_spec.rb
index 2580ab68732..b38a6ebbdad 100644
--- a/plugins/discourse-ai/spec/requests/admin/ai_translations_controller_spec.rb
+++ b/plugins/discourse-ai/spec/requests/admin/ai_translations_controller_spec.rb
@@ -23,7 +23,7 @@ describe DiscourseAi::Admin::AiTranslationsController do
end
it "returns base configuration data without progress" do
- SiteSetting.ai_translation_backfill_max_age_days = 30
+ SiteSetting.ai_translation_backfill_start_date = "2026-07-01"
SiteSetting.ai_translation_backfill_hourly_rate = 100
get "/admin/plugins/discourse-ai/ai-translations.json"
@@ -35,6 +35,7 @@ describe DiscourseAi::Admin::AiTranslationsController do
expect(json["enabled"]).to eq(true)
expect(json["translation_enabled"]).to eq(true)
expect(json["hourly_rate"]).to eq(100)
+ expect(json["backfill_start_date"]).to eq("2026-07-01")
expect(json["backfill_enabled"]).to be_in([true, false])
expect(json).not_to have_key("translation_progress")
@@ -63,8 +64,6 @@ describe DiscourseAi::Admin::AiTranslationsController do
end
it "returns translation_enabled field" do
- SiteSetting.ai_translation_backfill_max_age_days = 30
-
get "/admin/plugins/discourse-ai/ai-translations.json"
expect(response.status).to eq(200)
@@ -83,6 +82,7 @@ describe DiscourseAi::Admin::AiTranslationsController do
end
it "correctly indicates if backfill is enabled" do
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
SiteSetting.ai_translation_backfill_hourly_rate = 30
get "/admin/plugins/discourse-ai/ai-translations.json"
@@ -96,6 +96,14 @@ describe DiscourseAi::Admin::AiTranslationsController do
expect(response.status).to eq(200)
expect(response.parsed_body["backfill_enabled"]).to eq(false)
+
+ SiteSetting.ai_translation_backfill_hourly_rate = 30
+ SiteSetting.ai_translation_backfill_start_date = ""
+
+ get "/admin/plugins/discourse-ai/ai-translations.json"
+
+ expect(response.status).to eq(200)
+ expect(response.parsed_body["backfill_enabled"]).to eq(false)
end
it "returns category scope settings" do
@@ -123,14 +131,14 @@ describe DiscourseAi::Admin::AiTranslationsController do
end
it "correctly indicates if feature is enabled" do
- SiteSetting.ai_translation_backfill_max_age_days = 30
+ SiteSetting.ai_translation_backfill_start_date = 30.days.ago.utc.to_date.iso8601
get "/admin/plugins/discourse-ai/ai-translations.json"
expect(response.status).to eq(200)
expect(response.parsed_body["enabled"]).to eq(true)
- SiteSetting.ai_translation_backfill_max_age_days = 0
+ SiteSetting.ai_translation_backfill_start_date = ""
get "/admin/plugins/discourse-ai/ai-translations.json"
@@ -230,8 +238,8 @@ describe DiscourseAi::Admin::AiTranslationsController do
expect(DiscourseAi::Translation::Progress).to have_received(:fetch)
end
- it "returns progress when the post backfill age is zero" do
- SiteSetting.ai_translation_backfill_max_age_days = 0
+ it "returns progress when the backfill start date is blank" do
+ SiteSetting.ai_translation_backfill_start_date = ""
get "/admin/plugins/discourse-ai/ai-translations/progress.json"
diff --git a/plugins/discourse-ai/spec/system/admin_ai_translations_spec.rb b/plugins/discourse-ai/spec/system/admin_ai_translations_spec.rb
index 18248de2e03..26bbc06985d 100644
--- a/plugins/discourse-ai/spec/system/admin_ai_translations_spec.rb
+++ b/plugins/discourse-ai/spec/system/admin_ai_translations_spec.rb
@@ -60,7 +60,6 @@ describe "Admin AI translations" do
SiteSetting.ai_translation_enabled = true
SiteSetting.content_localization_supported_locales = "en|fr|es"
SiteSetting.ai_translation_backfill_hourly_rate = 10
- SiteSetting.ai_translation_backfill_max_age_days = 30
translations_page.visit
end
@@ -170,7 +169,6 @@ describe "Admin AI translations" do
SiteSetting.content_localization_supported_locales = "en|fr|es"
SiteSetting.ai_translation_category_scope = "include"
SiteSetting.ai_translation_categories = category.id.to_s
- SiteSetting.ai_translation_backfill_max_age_days = 30
translations_page.visit
end
@@ -196,7 +194,6 @@ describe "Admin AI translations" do
SiteSetting.discourse_ai_enabled = true
SiteSetting.ai_translation_enabled = false
SiteSetting.content_localization_supported_locales = ""
- SiteSetting.ai_translation_backfill_max_age_days = 30
translations_page.visit
end
@@ -234,7 +231,6 @@ describe "Admin AI translations" do
SiteSetting.content_localization_supported_locales = "en|fr"
SiteSetting.ai_translation_category_scope = "include"
SiteSetting.ai_translation_categories = ""
- SiteSetting.ai_translation_backfill_max_age_days = 30
visit "/admin/plugins/discourse-ai/ai-translations"
end
@@ -261,7 +257,6 @@ describe "Admin AI translations" do
before do
SiteSetting.discourse_ai_enabled = true
SiteSetting.content_localization_supported_locales = "en|fr"
- SiteSetting.ai_translation_backfill_max_age_days = 30
end
it "displays the translation toggle" do
diff --git a/plugins/discourse-ai/test/javascripts/integration/components/ai-translations-test.gjs b/plugins/discourse-ai/test/javascripts/integration/components/ai-translations-test.gjs
index 699bc8dffd7..ae656473cb5 100644
--- a/plugins/discourse-ai/test/javascripts/integration/components/ai-translations-test.gjs
+++ b/plugins/discourse-ai/test/javascripts/integration/components/ai-translations-test.gjs
@@ -167,4 +167,34 @@ module("Integration | Component | AiTranslations", function (hooks) {
.dom(".ai-translation-locale-progress__translated-value")
.hasText("8", "the refreshed response is rendered");
});
+
+ test("shows the fixed backfill start date", async function (assert) {
+ this.owner.lookup("service:router").urlFor = () =>
+ "/admin/plugins/discourse-ai/ai-features/6/edit";
+ const backfillStartDate = "2026-07-01";
+ const formattedDate = new Date(backfillStartDate).toLocaleDateString(
+ undefined,
+ {
+ year: "numeric",
+ month: "long",
+ day: "numeric",
+ timeZone: "UTC",
+ }
+ );
+ this.model = {
+ ...this.model,
+ backfill_enabled: true,
+ backfill_start_date: backfillStartDate,
+ hourly_rate: 50,
+ };
+
+ await render(<template><AiTranslations @model={{this.model}} /></template>);
+
+ assert
+ .dom(".ai-translations__stat-label")
+ .includesText(
+ formattedDate,
+ "the status uses the configured fixed cutoff date"
+ );
+ });
});
diff --git a/plugins/discourse-ai/test/javascripts/unit/lib/ai-feature-setting-groups-test.js b/plugins/discourse-ai/test/javascripts/unit/lib/ai-feature-setting-groups-test.js
index 8c74aec4771..88e974644a7 100644
--- a/plugins/discourse-ai/test/javascripts/unit/lib/ai-feature-setting-groups-test.js
+++ b/plugins/discourse-ai/test/javascripts/unit/lib/ai-feature-setting-groups-test.js
@@ -78,6 +78,10 @@ module("Unit | Lib | ai-feature-setting-groups", function () {
const groups = getSettingGroupsForFeature("translation");
assert.strictEqual(groups.length, 3, "translation should have 3 groups");
+ assert.true(
+ groups[2].settings.includes("ai_translation_backfill_start_date"),
+ "backfill should include the fixed start date"
+ );
});
test("returns correct groups for discord", function (assert) {
diff --git a/spec/lib/site_settings/type_supervisor_spec.rb b/spec/lib/site_settings/type_supervisor_spec.rb
index 59c57f42809..f9728497c6c 100644
--- a/spec/lib/site_settings/type_supervisor_spec.rb
+++ b/spec/lib/site_settings/type_supervisor_spec.rb
@@ -102,6 +102,9 @@ RSpec.describe SiteSettings::TypeSupervisor do
it "'datetime' should be at the right position" do
expect(SiteSettings::TypeSupervisor.types[:datetime]).to eq(31)
end
+ it "'date' should be at the right position" do
+ expect(SiteSettings::TypeSupervisor.types[:date]).to eq(33)
+ end
end
end
@@ -178,6 +181,7 @@ RSpec.describe SiteSettings::TypeSupervisor do
settings.setting(:type_false, false)
settings.setting(:type_float, 2.3232)
settings.setting(:type_string, "string")
+ settings.setting(:type_date, "2024-01-01", type: "date")
settings.setting(:type_enum_default_string, "2", type: "enum", choices: ["2"])
settings.setting(:type_enum_class, "en", enum: "TestEnumClass")
settings.setting(:type_validator, 5, validator: "TestSmallThanTenValidator")
@@ -261,6 +265,13 @@ RSpec.describe SiteSettings::TypeSupervisor do
]
end
+ it "returns date values" do
+ expect(settings.type_supervisor.to_db_value(:type_date, "2024-12-29")).to eq [
+ "2024-12-29",
+ SiteSetting.types[:date],
+ ]
+ end
+
it "returns the upload id" do
upload = Fabricate(:upload)
@@ -471,6 +482,7 @@ RSpec.describe SiteSettings::TypeSupervisor do
settings.setting(:type_true, true)
settings.setting(:type_float, 2.3232)
settings.setting(:type_string, "string")
+ settings.setting(:type_date, "2024-01-01", type: "date")
settings.setting(:type_url_list, "string", type: "url_list")
settings.setting(:type_textarea, "string", textarea: true)
settings.setting(:type_enum_choices, "2", type: "enum", choices: %w[1 2])
@@ -512,6 +524,10 @@ RSpec.describe SiteSettings::TypeSupervisor do
expect(settings.type_supervisor.type_hash(:type_string)[:type]).to eq "string"
end
+ it "returns date type" do
+ expect(settings.type_supervisor.type_hash(:type_date)[:type]).to eq "date"
+ end
+
it "returns url_list type" do
expect(settings.type_supervisor.type_hash(:type_url_list)[:type]).to eq "url_list"
end
diff --git a/spec/lib/validators/date_setting_validator_spec.rb b/spec/lib/validators/date_setting_validator_spec.rb
new file mode 100644
index 00000000000..7e2771a4a22
--- /dev/null
+++ b/spec/lib/validators/date_setting_validator_spec.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+describe DateSettingValidator do
+ subject(:validator) { described_class.new }
+
+ it "accepts blank and ISO 8601 date values" do
+ expect(validator.valid_value?("")).to eq(true)
+ expect(validator.valid_value?(nil)).to eq(true)
+ expect(validator.valid_value?("2026-07-01")).to eq(true)
+ end
+
+ it "rejects datetimes and non-ISO date values" do
+ expect(validator.valid_value?("2026-07-01T00:00:00Z")).to eq(false)
+ expect(validator.valid_value?("01/07/2026")).to eq(false)
+ expect(validator.valid_value?("2026-02-30")).to eq(false)
+ end
+end