Skip to content

A platform for community discussion. Free, open, simple.

DEV: Stabilize bot sorting and tied like report specs (#45534)

Alan Guo Xiang Tan7ca202317565
diff --git a/spec/lib/admin_user_index_query_spec.rb b/spec/lib/admin_user_index_query_spec.rb
index edf984479ea..414009a8d16 100644
--- a/spec/lib/admin_user_index_query_spec.rb
+++ b/spec/lib/admin_user_index_query_spec.rb
@@ -160,7 +160,7 @@ RSpec.describe AdminUserIndexQuery do
end
it "sorts bot activity and creation dates in both directions" do
- other_bot = Fabricate(:user, id: -102, created_at: 2.days.ago)
+ other_bot = Fabricate(:user, id: -102, username: "other_bot", created_at: 2.days.ago)
bot.update!(created_at: 1.day.ago)
bot.user_stat.update!(topics_entered: 2, posts_read_count: 4, post_count: 6)
other_bot.user_stat.update!(topics_entered: 1, posts_read_count: 3, post_count: 5)
diff --git a/spec/models/report_spec.rb b/spec/models/report_spec.rb
index a5dbf981874..100c020877d 100644
--- a/spec/models/report_spec.rb
+++ b/spec/models/report_spec.rb
@@ -2327,10 +2327,7 @@ RSpec.describe Report do
it "with category filtering" do
report = Report.find("top_users_by_likes_received_from_a_variety_of_people")
- expect(report.data.length).to eq(3)
- expect(report.data[0][:username]).to eq("jonah")
- expect(report.data[1][:username]).to eq("jake")
- expect(report.data[2][:username]).to eq("john")
+ expect(report.data.map { |row| row[:username] }).to contain_exactly("jonah", "jake", "john")
end
end
end