A platform for community discussion. Free, open, simple.
DEV: Add @placeholder argument to FKInput via FKFieldData (#39630)
Martin Brennan801fdc1f89be
diff --git a/frontend/discourse/app/form-kit/components/fk/control/input.gjs b/frontend/discourse/app/form-kit/components/fk/control/input.gjsindex c5732701fa2..991a8ca0cda 100644--- a/frontend/discourse/app/form-kit/components/fk/control/input.gjs+++ b/frontend/discourse/app/form-kit/components/fk/control/input.gjs@@ -109,6 +109,7 @@ export default class FKControlInput extends FKBaseControl {name={{@field.name}}aria-invalid={{if @field.error "true"}}aria-describedby={{if @field.error @field.errorId}}+ placeholder={{@field.placeholder}}...attributes{{on "focus" this.handleFocus}}{{on "blur" this.handleBlur}}diff --git a/frontend/discourse/app/form-kit/components/fk/field-data.gjs b/frontend/discourse/app/form-kit/components/fk/field-data.gjsindex a4f5b9ea85d..5ab9af03db8 100644--- a/frontend/discourse/app/form-kit/components/fk/field-data.gjs+++ b/frontend/discourse/app/form-kit/components/fk/field-data.gjs@@ -160,6 +160,14 @@ export default class FKFieldData extends Component {return this.args.description;}+ /**+ * Placeholder text for input fields.+ * @type {string}+ */+ get placeholder() {+ return this.args.placeholder;+ }+/*** Help text of the field.* @type {string}diff --git a/frontend/discourse/tests/integration/components/form-kit/controls/input-text-test.gjs b/frontend/discourse/tests/integration/components/form-kit/controls/input-text-test.gjsindex 3b961356c0f..dc27321e15a 100644--- a/frontend/discourse/tests/integration/components/form-kit/controls/input-text-test.gjs+++ b/frontend/discourse/tests/integration/components/form-kit/controls/input-text-test.gjs@@ -90,5 +90,30 @@ module(assert.dom(".form-kit__control-input").hasClass("has-prefix");assert.dom(".form-kit__control-input").hasClass("has-suffix");});++ test("disabled, name, and placeholder attributes", async function (assert) {+ await render(+ <template>+ <Form as |form|>+ <form.Field+ @type="input"+ @name="foo"+ @title="Foo"+ @disabled={{true}}+ @placeholder="Enter text"+ as |field|+ >+ <field.Control />+ </form.Field>+ </Form>+ </template>+ );++ assert.dom(".form-kit__control-input").hasAttribute("disabled");+ assert.dom(".form-kit__control-input").hasAttribute("name", "foo");+ assert+ .dom(".form-kit__control-input")+ .hasAttribute("placeholder", "Enter text");+ });});