Skip to content

A platform for community discussion. Free, open, simple.

FIX: skip badge trigger when user_stat's user is gone

Jake Goldsborough81a3dd6d133d
diff --git a/app/models/user_stat.rb b/app/models/user_stat.rb
index e230ac78e31..219e658e84b 100644
--- a/app/models/user_stat.rb
+++ b/app/models/user_stat.rb
@@ -358,6 +358,11 @@ class UserStat < ActiveRecord::Base
protected
def trigger_badges
+ # the user row can already be gone when a save happens mid-deletion
+ # (e.g. a stale user_stat created or touched while rendering review
+ # queues), and queueing a grant for a missing user raises through
+ # after_save and takes the request down
+ return if user.nil?
BadgeGranter.queue_badge_grant(Badge::Trigger::UserChange, user: user)
end
end
diff --git a/spec/models/user_stat_spec.rb b/spec/models/user_stat_spec.rb
index e0f6dec9adf..5b1e9338a31 100644
--- a/spec/models/user_stat_spec.rb
+++ b/spec/models/user_stat_spec.rb
@@ -388,4 +388,25 @@ RSpec.describe UserStat do
update_pending_posts
end
end
+
+ describe "trigger_badges" do
+ fab!(:user)
+
+ it "queues a badge grant for the user when present" do
+ stat = user.user_stat
+
+ BadgeGranter.expects(:queue_badge_grant).with(Badge::Trigger::UserChange, user:)
+
+ stat.save!
+ end
+
+ it "does not raise when the user row is gone" do
+ stat = user.user_stat
+ User.where(id: user.id).delete_all
+ stat.reload
+ expect(stat.user).to be_nil
+
+ expect { stat.save! }.not_to raise_error
+ end
+ end
end