A platform for community discussion. Free, open, simple.
DEV: change from GET to POST in chat_summary#show (#38495)
Gabriel Grubba85d0ef095c3f
diff --git a/plugins/discourse-ai/assets/javascripts/discourse/components/modal/chat-modal-channel-summary.gjs b/plugins/discourse-ai/assets/javascripts/discourse/components/modal/chat-modal-channel-summary.gjsindex bee0b87e160..86ccd2fdd13 100644--- a/plugins/discourse-ai/assets/javascripts/discourse/components/modal/chat-modal-channel-summary.gjs+++ b/plugins/discourse-ai/assets/javascripts/discourse/components/modal/chat-modal-channel-summary.gjs@@ -32,7 +32,7 @@ export default class ChatModalChannelSummary extends Component {}@action- summarize(since) {+ async summarize(since) {this.sinceHours = since;this.loading = true;@@ -42,24 +42,27 @@ export default class ChatModalChannelSummary extends Component {return;}- return ajax(`/discourse-ai/summarization/channels/${this.channelId}.json`, {- type: "GET",- data: {- since,- },- })- .then((data) => {- this.availableSummaries[this.sinceHours] = data.summary;- this.summary = this.availableSummaries[this.sinceHours];- })- .catch((error) => {- if (isAiCreditLimitError(error)) {- popupAiCreditLimitError(error);- } else {- popupAjaxError(error);+ try {+ const data = await ajax(+ `/discourse-ai/summarization/channels/${this.channelId}.json`,+ {+ type: "POST",+ data: {+ since,+ },}- })- .finally(() => (this.loading = false));+ );+ this.availableSummaries[this.sinceHours] = data.summary;+ this.summary = this.availableSummaries[this.sinceHours];+ } catch (error) {+ if (isAiCreditLimitError(error)) {+ popupAiCreditLimitError(error);+ } else {+ popupAjaxError(error);+ }+ } finally {+ this.loading = false;+ }}<template>diff --git a/plugins/discourse-ai/config/routes.rb b/plugins/discourse-ai/config/routes.rbindex d3fcfa5f2eb..30b9ff52c02 100644--- a/plugins/discourse-ai/config/routes.rb+++ b/plugins/discourse-ai/config/routes.rb@@ -64,7 +64,7 @@ DiscourseAi::Engine.routes.draw doget "/t/:topic_id" => "summary#show", :constraints => { topic_id: /\d+/ }put "/regen_gist" => "summary#regen_gist"put "/regen_summary" => "summary#regen_summary"- get "/channels/:channel_id" => "chat_summary#show"+ post "/channels/:channel_id" => "chat_summary#show"endscope module: :sentiment, path: "/sentiment", defaults: { format: :json } dodiff --git a/plugins/discourse-ai/spec/requests/summarization/chat_summary_controller_spec.rb b/plugins/discourse-ai/spec/requests/summarization/chat_summary_controller_spec.rbindex ddb505fce36..13ea0d5b08a 100644--- a/plugins/discourse-ai/spec/requests/summarization/chat_summary_controller_spec.rb+++ b/plugins/discourse-ai/spec/requests/summarization/chat_summary_controller_spec.rb@@ -18,11 +18,29 @@ RSpec.describe DiscourseAi::Summarization::ChatSummaryController doenddescribe "#show" do+ context "when the user can join the channel" do+ fab!(:channel, :category_channel)+ fab!(:message) { Fabricate(:chat_message, chat_channel: channel) }++ before { assign_agent_to(:ai_summarization_agent, [group.id]) }++ it "returns a summary" do+ summary = "This is a summary"++ DiscourseAi::Completions::Llm.with_prepared_responses([summary]) do+ post "/discourse-ai/summarization/channels/#{channel.id}.json", params: { since: 6 }++ expect(response.status).to eq(200)+ expect(response.parsed_body["summary"]).to eq(summary)+ end+ end+ end+context "when the user is not allowed to join the channel" dofab!(:channel, :private_category_channel)it "returns a 403" do- get "/discourse-ai/summarization/channels/#{channel.id}", params: { since: 6 }+ post "/discourse-ai/summarization/channels/#{channel.id}", params: { since: 6 }expect(response.status).to eq(403)enddiff --git a/plugins/discourse-ai/spec/system/summarization/chat_summarization_spec.rb b/plugins/discourse-ai/spec/system/summarization/chat_summarization_spec.rbindex 536052e0010..59e947b7978 100644--- a/plugins/discourse-ai/spec/system/summarization/chat_summarization_spec.rb+++ b/plugins/discourse-ai/spec/system/summarization/chat_summarization_spec.rb@@ -30,7 +30,7 @@ RSpec.describe "Summarize a channel since your last visit", type: :system dofind(".chat-composer-dropdown__trigger-btn").clickfind(".chat-composer-dropdown__action-btn.channel-summary").click- expect(page.has_css?(".chat-modal-channel-summary")).to eq(true)+ expect(page).to have_css(".chat-modal-channel-summary")find(".summarization-since").clickfind(".select-kit-row[data-value=\"3\"]").click