Skip to content

A platform for community discussion. Free, open, simple.

FIX: Handle connection resets when fetching titles (#42461)

Sam8ba710c61291
diff --git a/lib/retrieve_title.rb b/lib/retrieve_title.rb
index e550df7c166..8ec16002d27 100644
--- a/lib/retrieve_title.rb
+++ b/lib/retrieve_title.rb
@@ -3,6 +3,7 @@
module RetrieveTitle
CRAWL_TIMEOUT = 1
UNRECOVERABLE_ERRORS = [
+ Errno::ECONNRESET,
Net::ReadTimeout,
FinalDestination::SSRFError,
FinalDestination::UrlEncodingError,
@@ -16,7 +17,7 @@ module RetrieveTitle
headers: headers,
)
rescue *UNRECOVERABLE_ERRORS
- # ¯\_(ツ)_/¯
+ nil
end
def self.extract_title(html, encoding = nil)
diff --git a/spec/lib/retrieve_title_spec.rb b/spec/lib/retrieve_title_spec.rb
index 1a3cc239774..74815cbdf9f 100644
--- a/spec/lib/retrieve_title_spec.rb
+++ b/spec/lib/retrieve_title_spec.rb
@@ -202,6 +202,12 @@ RSpec.describe RetrieveTitle do
expect(RetrieveTitle.crawl("https://example.com")).to eq(nil)
end
+ it "ignores connection reset errors" do
+ described_class.stubs(:fetch_title).raises(Errno::ECONNRESET)
+
+ expect(RetrieveTitle.crawl("https://example.com")).to eq(nil)
+ end
+
it "ignores SSRF lookup errors" do
described_class.stubs(:fetch_title).raises(FinalDestination::SSRFDetector::LookupFailedError)