A platform for community discussion. Free, open, simple.
FIX: Handle connection resets when fetching titles (#42461)
Sam8ba710c61291
diff --git a/lib/retrieve_title.rb b/lib/retrieve_title.rbindex e550df7c166..8ec16002d27 100644--- a/lib/retrieve_title.rb+++ b/lib/retrieve_title.rb@@ -3,6 +3,7 @@module RetrieveTitleCRAWL_TIMEOUT = 1UNRECOVERABLE_ERRORS = [+ Errno::ECONNRESET,Net::ReadTimeout,FinalDestination::SSRFError,FinalDestination::UrlEncodingError,@@ -16,7 +17,7 @@ module RetrieveTitleheaders: headers,)rescue *UNRECOVERABLE_ERRORS- # ¯\_(ツ)_/¯+ nilenddef self.extract_title(html, encoding = nil)diff --git a/spec/lib/retrieve_title_spec.rb b/spec/lib/retrieve_title_spec.rbindex 1a3cc239774..74815cbdf9f 100644--- a/spec/lib/retrieve_title_spec.rb+++ b/spec/lib/retrieve_title_spec.rb@@ -202,6 +202,12 @@ RSpec.describe RetrieveTitle doexpect(RetrieveTitle.crawl("https://example.com")).to eq(nil)end+ it "ignores connection reset errors" do+ described_class.stubs(:fetch_title).raises(Errno::ECONNRESET)++ expect(RetrieveTitle.crawl("https://example.com")).to eq(nil)+ end+it "ignores SSRF lookup errors" dodescribed_class.stubs(:fetch_title).raises(FinalDestination::SSRFDetector::LookupFailedError)