A platform for community discussion. Free, open, simple.
FIX: Add visibility check to Embed info (#40896)
Isaac Janzen8bf698d78f45
diff --git a/app/controllers/embed_controller.rb b/app/controllers/embed_controller.rbindex 4019bf7236f..e2a19520b6a 100644--- a/app/controllers/embed_controller.rb+++ b/app/controllers/embed_controller.rb@@ -137,7 +137,7 @@ class EmbedController < ApplicationControllerembed_url = params.require(:embed_url)@topic_embed = TopicEmbed.where(embed_url: embed_url).first- raise Discourse::NotFound if @topic_embed.nil?+ raise Discourse::NotFound if @topic_embed.nil? || !guardian.can_see?(@topic_embed.topic)render_serialized(@topic_embed, TopicEmbedSerializer, root: false)enddiff --git a/spec/requests/embed_controller_spec.rb b/spec/requests/embed_controller_spec.rbindex 2bc8bea3aca..f77bb568db6 100644--- a/spec/requests/embed_controller_spec.rb+++ b/spec/requests/embed_controller_spec.rb@@ -35,6 +35,35 @@ RSpec.describe EmbedController doexpect(response.parsed_body["post_id"]).to eq(topic_embed.post.id)expect(response.parsed_body["topic_slug"]).to eq(topic_embed.topic.slug)end++ it "returns not found for topics the API user cannot see" do+ user = Fabricate(:user)+ api_key = Fabricate(:api_key, user: user)+ restricted_category = Fabricate(:category)+ restricted_category.set_permissions(staff: :full)+ restricted_category.save!+ restricted_topic = Fabricate(:topic, category: restricted_category, posts_count: 5)+ restricted_topic_embed =+ Fabricate(+ :topic_embed,+ post: Fabricate(:post, topic: restricted_topic),+ topic: restricted_topic,+ embed_url: "http://eviltrout.com/private-article",+ )++ get "/embed/info.json",+ params: {+ embed_url: restricted_topic_embed.embed_url,+ },+ headers: {+ HTTP_API_KEY: api_key.key,+ HTTP_API_USERNAME: user.username,+ }++ expect(response.status).to eq(404)+ expect(response.parsed_body["error_type"]).to eq("not_found")+ expect(response.body).not_to include(restricted_topic.slug)+ endendcontext "without invalid embed url" do