Skip to content

A platform for community discussion. Free, open, simple.

DEV: Guard the similar-topics lookup against absent form template ids (#42612)

Sérgio Saquetim8c0e4286f33e
diff --git a/frontend/discourse/app/components/composer-messages.gjs b/frontend/discourse/app/components/composer-messages.gjs
index 19b4018e26b..179fface329 100644
--- a/frontend/discourse/app/components/composer-messages.gjs
+++ b/frontend/discourse/app/components/composer-messages.gjs
@@ -234,7 +234,7 @@ export default class ComposerMessages extends Component {
}
// We don't care about similar topics when creating with a form template
- if (this.composer?.category?.form_template_ids.length > 0) {
+ if (this.composer?.category?.form_template_ids?.length > 0) {
return;
}
diff --git a/frontend/discourse/tests/acceptance/composer-messages-test.js b/frontend/discourse/tests/acceptance/composer-messages-test.js
index 1270da2bd82..3d5bf6e9224 100644
--- a/frontend/discourse/tests/acceptance/composer-messages-test.js
+++ b/frontend/discourse/tests/acceptance/composer-messages-test.js
@@ -329,3 +329,39 @@ acceptance("Composer - Messages - Private Messages", function (needs) {
);
});
});
+
+acceptance("Composer - Messages - Similar topics", function (needs) {
+ needs.user();
+ needs.settings({
+ general_category_id: 1,
+ default_composer_category: 1,
+ });
+ needs.site({
+ categories: [{ id: 1, name: "General", slug: "general", permission: 1 }],
+ });
+
+ test("a key release survives a category that carries no form template ids", async function (assert) {
+ await visit("/");
+ await click("#create-topic");
+
+ // Asserted, not assumed: the lookup returns early without a topic being
+ // created, and never reaches the guard without a category.
+ const { model } = this.container.lookup("service:composer");
+ assert.true(model.creatingTopic, "a topic is being created");
+ assert.true(!!model.category, "the composer has a category");
+ assert.strictEqual(
+ model.category.form_template_ids,
+ undefined,
+ "whose payload carries no form template ids"
+ );
+
+ // Only a real key release schedules the lookup, so `fillIn` cannot stand in
+ // here. The releases in the modules above go to a private message, which the
+ // lookup declines before reaching this guard.
+ await triggerKeyEvent(".d-editor-input", "keyup", "A");
+
+ assert
+ .dom("#reply-control")
+ .exists("the scheduled lookup runs without throwing");
+ });
+});