Skip to content

A platform for community discussion. Free, open, simple.

DEV: Fix flaky poll specs (#39722)

Jarek Radosz8cb0261edee5
diff --git a/plugins/poll/spec/lib/poll_spec.rb b/plugins/poll/spec/lib/poll_spec.rb
index 8d3e9dfdd81..6bd9151cf89 100644
--- a/plugins/poll/spec/lib/poll_spec.rb
+++ b/plugins/poll/spec/lib/poll_spec.rb
@@ -387,6 +387,7 @@ RSpec.describe DiscoursePoll::Poll do
it "returns all serialized voters" do
voters = DiscoursePoll::Poll.serialized_voters(poll)
+ voters.transform_values! { |users| users.sort_by { |u| u[:id] } }
expect(voters).to eq(
{
poll_options.first.digest => [
@@ -401,6 +402,7 @@ RSpec.describe DiscoursePoll::Poll do
it "correctly paginates voters" do
opts = { page: 1, limit: 2 }.with_indifferent_access
voters = DiscoursePoll::Poll.serialized_voters(poll, opts)
+ voters.transform_values! { |users| users.sort_by { |u| u[:id] } }
expect(voters).to eq(
{
poll_options.first.digest => [
@@ -439,6 +441,7 @@ RSpec.describe DiscoursePoll::Poll do
it "returns all serialized voters" do
voters = DiscoursePoll::Poll.serialized_voters(poll)
+ voters.transform_values! { |users| users.sort_by { |u| u[:id] } }
expect(voters).to eq(
{
poll_options.first.digest => [UserNameSerializer.new(user).serializable_hash],
@@ -459,6 +462,7 @@ RSpec.describe DiscoursePoll::Poll do
it "correctly paginates voters" do
opts = { page: 1, limit: 2 }.with_indifferent_access
voters = DiscoursePoll::Poll.serialized_voters(poll, opts)
+ voters.transform_values! { |users| users.sort_by { |u| u[:id] } }
expect(voters).to eq(
{
poll_options.first.digest => [UserNameSerializer.new(user).serializable_hash],
@@ -476,6 +480,7 @@ RSpec.describe DiscoursePoll::Poll do
opts = { page: 2, limit: 2 }.with_indifferent_access
voters = DiscoursePoll::Poll.serialized_voters(poll, opts)
+ voters.transform_values! { |users| users.sort_by { |u| u[:id] } }
expect(voters).to eq(
{ poll_options.second.digest => [UserNameSerializer.new(user_3).serializable_hash] },
)