Skip to content

A platform for community discussion. Free, open, simple.

DEV: Fix AI logs page system spec period selection (#42832)

Martin Brennan9092c8e5acb1
diff --git a/plugins/discourse-ai/spec/system/ai_logs_spec.rb b/plugins/discourse-ai/spec/system/ai_logs_spec.rb
index d0845a971fd..3ca5564d0fb 100644
--- a/plugins/discourse-ai/spec/system/ai_logs_spec.rb
+++ b/plugins/discourse-ai/spec/system/ai_logs_spec.rb
@@ -82,15 +82,15 @@ RSpec.describe "AI logs admin page" do
expect(ai_logs_page).to have_no_log(log)
day_period = I18n.t("js.discourse_ai.logs.periods.day")
- click_button day_period
- expect(page).to have_css('button[aria-pressed="true"]', text: day_period)
+ ai_logs_page.select_period(day_period)
+ expect(ai_logs_page).to have_filter_value(:period, "day")
find("input[placeholder='#{I18n.t("js.discourse_ai.logs.id_placeholder")}']").fill_in(
with: log.id,
)
find(".ai-logs__id-filter .btn", text: I18n.t("js.discourse_ai.logs.find")).click
expect(ai_logs_page).to have_no_log(log)
- expect(page).to have_css('button[aria-pressed="true"]', text: day_period)
+ expect(ai_logs_page).to have_filter_value(:period, "day")
ai_logs_page.select_feature(log.feature_name)
expect(ai_logs_page).to have_log(log)
diff --git a/plugins/discourse-ai/spec/system/page_objects/pages/ai_logs.rb b/plugins/discourse-ai/spec/system/page_objects/pages/ai_logs.rb
index 767f61c705c..f238caa681d 100644
--- a/plugins/discourse-ai/spec/system/page_objects/pages/ai_logs.rb
+++ b/plugins/discourse-ai/spec/system/page_objects/pages/ai_logs.rb
@@ -34,6 +34,10 @@ module PageObjects
find(".d-filter-controls__dropdown--#{key}").value
end
+ def has_filter_value?(key, value)
+ find(".d-filter-controls__dropdown--#{key}").value == value
+ end
+
def has_expanded_filter_dropdowns?
page.has_css?(".d-filter-controls__dropdown", count: 4)
end