Skip to content

A platform for community discussion. Free, open, simple.

UX: add unstyled-list mixin + replace (#41224)

chapoi90b9d68eda6a
diff --git a/app/assets/stylesheets/admin/admin-dashboard-skeleton.scss b/app/assets/stylesheets/admin/admin-dashboard-skeleton.scss
index ae50d14f3a3..67cf59f34d5 100644
--- a/app/assets/stylesheets/admin/admin-dashboard-skeleton.scss
+++ b/app/assets/stylesheets/admin/admin-dashboard-skeleton.scss
@@ -213,9 +213,7 @@
}
&__list {
- list-style: none;
- margin: 0;
- padding: 0;
+ @include unstyled-list;
display: flex;
flex-direction: column;
gap: var(--space-2);
diff --git a/app/assets/stylesheets/admin/admin_dashboard.scss b/app/assets/stylesheets/admin/admin_dashboard.scss
index ff1a3351897..02c2903fe52 100644
--- a/app/assets/stylesheets/admin/admin_dashboard.scss
+++ b/app/assets/stylesheets/admin/admin_dashboard.scss
@@ -127,9 +127,7 @@
padding: var(--space-4);
&__list {
- list-style: none;
- padding: 0;
- margin: 0;
+ @include unstyled-list;
display: flex;
flex-direction: column;
gap: var(--space-3);
@@ -700,9 +698,7 @@
gap: var(--space-2);
&__rows {
- list-style: none;
- padding: 0;
- margin: 0;
+ @include unstyled-list;
display: flex;
flex-direction: column;
gap: var(--space-5);
@@ -993,9 +989,8 @@
grid-template-columns: 1fr auto;
column-gap: var(--space-4);
row-gap: var(--space-2);
- list-style: none;
- margin: 0;
- padding: 0;
+
+ @include unstyled-list;
font-size: var(--font-down-1-rem);
}
diff --git a/app/assets/stylesheets/common/base/category-list.scss b/app/assets/stylesheets/common/base/category-list.scss
index 9d9903a71c9..4f4294f7705 100644
--- a/app/assets/stylesheets/common/base/category-list.scss
+++ b/app/assets/stylesheets/common/base/category-list.scss
@@ -499,9 +499,8 @@
ul {
color: var(--primary-medium);
- list-style: none;
- padding: 0;
- margin: 0;
+
+ @include unstyled-list;
}
li {
diff --git a/app/assets/stylesheets/common/base/discourse.scss b/app/assets/stylesheets/common/base/discourse.scss
index d452b8abe1b..21cb848b785 100644
--- a/app/assets/stylesheets/common/base/discourse.scss
+++ b/app/assets/stylesheets/common/base/discourse.scss
@@ -1215,9 +1215,7 @@ body.has-sidebar-page {
// todo: replace — legacy, currently only seems to be used for assigns
.mobile-nav {
- margin: 0;
- padding: 0;
- list-style: none;
+ @include unstyled-list;
position: relative;
a {
diff --git a/app/assets/stylesheets/common/base/list-controls.scss b/app/assets/stylesheets/common/base/list-controls.scss
index 519e129e8ce..e7f8f2cdd23 100644
--- a/app/assets/stylesheets/common/base/list-controls.scss
+++ b/app/assets/stylesheets/common/base/list-controls.scss
@@ -83,9 +83,8 @@
display: flex;
flex-wrap: wrap;
gap: var(--nav-space) 0; // used if the breadcrumb dropdowns wrap
- list-style: none;
- padding: 0;
- margin: 0;
+
+ @include unstyled-list;
> li {
// only target the top-level li, not dropdowns
diff --git a/app/assets/stylesheets/common/base/menu-panel.scss b/app/assets/stylesheets/common/base/menu-panel.scss
index adc050f86ec..729dd1c0cd0 100644
--- a/app/assets/stylesheets/common/base/menu-panel.scss
+++ b/app/assets/stylesheets/common/base/menu-panel.scss
@@ -198,9 +198,7 @@
}
ul {
- list-style: none;
- margin: 0;
- padding: 0;
+ @include unstyled-list;
}
.panel-body {
diff --git a/app/assets/stylesheets/common/base/review.scss b/app/assets/stylesheets/common/base/review.scss
index da88dd8b991..df4646528bc 100644
--- a/app/assets/stylesheets/common/base/review.scss
+++ b/app/assets/stylesheets/common/base/review.scss
@@ -488,9 +488,7 @@
.review-resources {
&__list {
- list-style: none;
- padding: 0;
- margin: 0;
+ @include unstyled-list;
display: flex;
flex-direction: column;
gap: var(--space-2);
diff --git a/app/assets/stylesheets/common/components/autocomplete.scss b/app/assets/stylesheets/common/components/autocomplete.scss
index f1fe96d8261..b9f85d82000 100644
--- a/app/assets/stylesheets/common/components/autocomplete.scss
+++ b/app/assets/stylesheets/common/components/autocomplete.scss
@@ -14,9 +14,7 @@
}
ul {
- list-style: none;
- padding: 0;
- margin: 0;
+ @include unstyled-list;
li {
&:first-of-type a {
diff --git a/app/assets/stylesheets/common/foundation/mixins.scss b/app/assets/stylesheets/common/foundation/mixins.scss
index 50f1426b93e..b29a7ea676f 100644
--- a/app/assets/stylesheets/common/foundation/mixins.scss
+++ b/app/assets/stylesheets/common/foundation/mixins.scss
@@ -415,3 +415,9 @@ $hpad: 0.65em;
}
}
}
+
+@mixin unstyled-list {
+ list-style: none;
+ padding: 0;
+ margin: 0;
+}
diff --git a/app/assets/stylesheets/common/modal/manage-reports-modal.scss b/app/assets/stylesheets/common/modal/manage-reports-modal.scss
index 14c51ed7042..6ab2a7a3327 100644
--- a/app/assets/stylesheets/common/modal/manage-reports-modal.scss
+++ b/app/assets/stylesheets/common/modal/manage-reports-modal.scss
@@ -20,9 +20,8 @@
&__list {
display: flex;
flex-direction: column;
- list-style: none;
- margin: 0;
- padding: 0;
+
+ @include unstyled-list;
}
&__row {
diff --git a/app/assets/stylesheets/common/modal/modal-overrides.scss b/app/assets/stylesheets/common/modal/modal-overrides.scss
index 4015442d0ee..5085f1a05bc 100644
--- a/app/assets/stylesheets/common/modal/modal-overrides.scss
+++ b/app/assets/stylesheets/common/modal/modal-overrides.scss
@@ -516,9 +516,7 @@
}
.formats {
- list-style: none;
- padding: 0;
- margin: 0;
+ @include unstyled-list;
.format {
.previewed-format {
diff --git a/app/assets/stylesheets/common/nested-view.scss b/app/assets/stylesheets/common/nested-view.scss
index f72ed0575a7..b914c5eb4d4 100644
--- a/app/assets/stylesheets/common/nested-view.scss
+++ b/app/assets/stylesheets/common/nested-view.scss
@@ -1052,9 +1052,7 @@
}
&__list {
- list-style: none;
- margin: 0;
- padding: 0;
+ @include unstyled-list;
}
&__item {
diff --git a/plugins/discourse-ai/assets/stylesheets/modules/ai-bot/common/ai-tools.scss b/plugins/discourse-ai/assets/stylesheets/modules/ai-bot/common/ai-tools.scss
index 16250c223fe..f826286d5cd 100644
--- a/plugins/discourse-ai/assets/stylesheets/modules/ai-bot/common/ai-tools.scss
+++ b/plugins/discourse-ai/assets/stylesheets/modules/ai-bot/common/ai-tools.scss
@@ -198,9 +198,7 @@
}
&__parameters {
- list-style: none;
- margin: 0;
- padding: 0;
+ @include unstyled-list;
display: grid;
gap: 0.75rem;
}
diff --git a/plugins/discourse-workflows/assets/stylesheets/common/context/schema-field.scss b/plugins/discourse-workflows/assets/stylesheets/common/context/schema-field.scss
index fab715e2305..ed09c6a603f 100644
--- a/plugins/discourse-workflows/assets/stylesheets/common/context/schema-field.scss
+++ b/plugins/discourse-workflows/assets/stylesheets/common/context/schema-field.scss
@@ -1,7 +1,5 @@
.workflows-schema-field-list {
- list-style: none;
- margin: 0;
- padding: 0;
+ @include unstyled-list;
&.is-nested {
padding-left: var(--space-9);
diff --git a/plugins/poll/assets/stylesheets/common/poll.scss b/plugins/poll/assets/stylesheets/common/poll.scss
index 5e175bc811c..15a0649a99d 100644
--- a/plugins/poll/assets/stylesheets/common/poll.scss
+++ b/plugins/poll/assets/stylesheets/common/poll.scss
@@ -19,9 +19,7 @@ div.poll-outer {
ul,
ol {
- margin: 0;
- padding: 0;
- list-style: none;
+ @include unstyled-list;
display: inline-block;
width: 100%;
}