A platform for community discussion. Free, open, simple.
SECURITY: An unauthorized user can delete emails of other users including Admins (#41927)
Isaac Janzen92439b84bfde
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rbindex b9d0a0acc68..f5e15ca41a2 100644--- a/app/controllers/users_controller.rb+++ b/app/controllers/users_controller.rb@@ -393,7 +393,7 @@ class UsersController < ApplicationControllerparams.require(:email)user = fetch_user_from_params- guardian.ensure_can_edit!(user)+ guardian.ensure_can_edit_email!(user)ActiveRecord::Base.transaction doif change_requests = user.email_change_requests.where(new_email: params[:email]).presencediff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rbindex 59316822322..da5a4440539 100644--- a/spec/requests/users_controller_spec.rb+++ b/spec/requests/users_controller_spec.rb@@ -4520,6 +4520,22 @@ RSpec.describe UsersController doexpect(response.parsed_body["error_type"]).to eq("not_logged_in")end+ it "prevents a moderator from destroying another user's secondary email" do+ SiteSetting.email_editable = true+ admin_secondary_email = Fabricate(:secondary_email, user: admin)+ sign_in(moderator)++ expect {+ delete "/u/#{admin.username}/preferences/email.json",+ params: {+ email: admin_secondary_email.email,+ }+ }.not_to change { UserEmail.exists?(admin_secondary_email.id) }++ expect(response).to be_forbidden+ expect(response.parsed_body["errors"]).to include(I18n.t("invalid_access"))+ end+context "when logged in" dobefore doSiteSetting.email_editable = true