Skip to content

A platform for community discussion. Free, open, simple.

UX: ensure inviting group to PM enables group inbox (#38919)

Kris92525e4fc192
diff --git a/app/models/topic.rb b/app/models/topic.rb
index 9bba0c07a5a..967d41972bf 100644
--- a/app/models/topic.rb
+++ b/app/models/topic.rb
@@ -1247,6 +1247,7 @@ class Topic < ActiveRecord::Base
def invite_group(user, group, should_notify: true)
TopicAllowedGroup.create!(topic_id: self.id, group_id: group.id)
+ group.update_columns(has_messages: true) unless group.has_messages
self.allowed_groups.reload
last_post =
diff --git a/spec/models/topic_spec.rb b/spec/models/topic_spec.rb
index dcfc428639e..b40e17ef032 100644
--- a/spec/models/topic_spec.rb
+++ b/spec/models/topic_spec.rb
@@ -1266,6 +1266,14 @@ RSpec.describe Topic do
expect(topic.allowed_groups.include?(admins)).to eq(false)
end
+ it "sets has_messages to true on the invited group" do
+ group.update!(messageable_level: Group::ALIAS_LEVELS[:everyone], has_messages: false)
+
+ topic.invite_group(topic.user, group)
+
+ expect(group.reload.has_messages).to eq(true)
+ end
+
def set_state!(group, user, state)
group
.group_users